-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Boost via cpm #1763
base: main2.0
Are you sure you want to change the base?
Adding Boost via cpm #1763
Conversation
Issue at cmake when adding boost::headers to the BoostAddons target... I'm not sure to understand the EXPORT issue. Any idea, @BDoignies ? |
Yes, you need to add the library "boost_headers" (not BOOST::Headers because this is an aliased name) to the things that are exported with the libraries. I think this is because there is no export rules in the boost.cmake file (unlike eigen.cmake:81) I am not sure where the boost.cmake comes from and left it untouch. But this is probably more appropriate to modify this file instead. Especially since the "boost_headers" target is somewhat obscure and not used directly in the linking process... |
Note: before sending the commit, I have not tried to compile the code, just to run the cmake. Looking at the error message, some boost/libraries are missing when creating the targets. |
Ok thx, the boost.cmake comes from adobe/lagange. |
My commit should clean up cmake and work (hopefully). When tried locally, DGtalTools was still linking to system boost. Fixing this requires a PR in DGtalTools to link against the correct boost library. As long as there are no boost cpp files in use, this should not be a problem. |
PR Description
Adding boost via CPM (not working yet because of BoostAddons --ping @BDoignies--).
Checklist