Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colored alpha SDP in meshViewer and alpha mesh in 3dSDPViewer #452

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

Seangongx
Copy link
Contributor

@Seangongx Seangongx commented Nov 3, 2023

Thanks a lot for contributing to DGtalTools, before submitting your PR, please fill up the description and make sure that all checkboxes are checked.

PR Description

  • Add colored SDP option in meshViewer when input texts are an alpha mesh and a colored SDP
  • Add alpha mesh option in 3dSDPViewer

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Github Actions C.I. will fail).
  • All continuous integration tests pass (Github Actions).

Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks! Could you please just add a new entry in the changelog.md as done in DGtal ?

@kerautret kerautret merged commit ac3f015 into DGtal-team:master Nov 30, 2023
4 checks passed
@kerautret
Copy link
Member

thanks @Seangongx merged ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants