Skip to content

Commit

Permalink
Hide dropdown menu instead of removing it from DOM (#881)
Browse files Browse the repository at this point in the history
* Hide dropdown menu instead of removing it from DOM

Note: no more smooth transition after this change

* Update CHANGELOG
  • Loading branch information
yaaax authored Dec 18, 2024
1 parent 0427bae commit 9a901bd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Tous les changements notables de Ara sont documentés ici avec leur date, leur c

### Corrections 🐛

- Corrige les menus déroulants en rendant le code HTML généré valide ([#881](https://github.com/DISIC/Ara/pull/881))
- Corrige la mauvaise position verticale dans la page après utilisation des ancres « Pages » du rapport ([#879](https://github.com/DISIC/Ara/pull/879))

## 13/12/2024
Expand Down
24 changes: 11 additions & 13 deletions confiture-web-app/src/components/ui/Dropdown.vue
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,17 @@ defineExpose({ buttonRef, closeOptions });
>
{{ title }}
</button>
<Transition>
<div
v-if="showContent"
:id="`dropdown-${uniqueId}`"
:class="[
'fr-p-2w dropdown-content',
{ 'dropdown-content-left': alignLeft }
]"
role="menu"
>
<slot />
</div>
</Transition>
<div
:id="`dropdown-${uniqueId}`"
:hidden="!showContent"
:class="[
'fr-p-2w dropdown-content',
{ 'dropdown-content-left': alignLeft }
]"
role="menu"
>
<slot />
</div>
</div>
</template>

Expand Down

0 comments on commit 9a901bd

Please sign in to comment.