-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajoute une liste éditable des élements transverse de l'audit #964
base: main
Are you sure you want to change the base?
The head ref may contain hidden characters: "780-rappel-des-\u00E9l\u00E9ments-audit\u00E9s-dans-longlet-transverse"
Ajoute une liste éditable des élements transverse de l'audit #964
Conversation
9060c88
to
a2ca35c
Compare
Faudrait aussi penser à l'affichage de ces informations côté rapport dans les onglets détail des nc et points d'amélioration |
Autres retours :
Affichage tags dans le rapport : https://www.figma.com/design/lbnXmYmTsTgkWvgzdR6W1c/Ara_V0.10_B%C3%AAta?node-id=7197-567337&t=K1wnQOjLLCFGRPO0-1 |
@@ -2,6 +2,12 @@ | |||
|
|||
Tous les changements notables de Ara sont documentés ici avec leur date, leur catégorie (nouvelle fonctionnalité, correction de bug ou autre changement) et leur pull request (PR) associée. | |||
|
|||
## 20/02/2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Penser à mettre à jour la date lors du merge
<button | ||
v-if="i === tags.length - 1" | ||
class="fr-btn fr-btn--sm fr-btn--tertiary-no-outline fr-btn--icon-left fr-icon-edit-fill fr-ml-1v edit-tags-button" | ||
@click="editing = true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Au click sur ce bouton, focus le champs de saisie pour ne pas perdre le focus.
}); | ||
} | ||
|
||
function cancelEdition() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Focus le bouton "Modifier" quand on annule pour ne pas perdre le focus.
...auditStore.currentAudit, | ||
transverseElements | ||
}) | ||
.then(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Focus le bouton "Modifier" quand on sauvegarde pour ne pas perdre le focus.
import { useAuditStore } from "../../store"; | ||
import DsfrField from "../ui/DsfrField.vue"; | ||
|
||
let nextUid = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On peut utiliser le hook useUniqueId()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useUniqueId
renvoie une ref, on est sensé s'en servir à la racine d'un setup
. Là on veut s'en servir des dans des fonctions
$emit('update:modelValue', ($event.target as HTMLInputElement).value) | ||
" | ||
/> | ||
<slot name="trailing" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je suis pas trop sûr de ce à quoi ça sert 🤔 . De ce que je comprends c'est pour insérer un bouton à côté mais dans ce cas c'est pas possible de créer un container flex 2 colonnes avec d'un côté le <DsfrField />
et e l'autre un bouton ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaah je vois 👍🏼
Il faudrait ajouter un |
closes #780
Avant de merger la pull request, s’assurer que :