File mounter refactoring #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FileMounter is just a light wrapper around the nix::mount call. It is moved to a separate submodule to keep things organized and modular.
…r initialization The use of an associated function `FileMounter::from_paths(PathBuf, PathBuf)` is more intuitive than using `TryFrom<&(PathBuf, PathBuf)>`.
…o relative path If a FileMounter is initialized with an absolute target path, this path is converted to a relative path by stripping the first '/'. This is a hidden conversion not documented anywhere, which may lead to unexpected behaviour. The conversion is now replaced with an error stating that the target directory must be relative.
…relative Previously absolute paths got converted silently into relative ones by stripping the first '/'. Now that this conversion is removed, the dev_random example is also required to use relative paths.
sevenautumns
requested changes
Feb 20, 2024
…bsolute The target path is then internally converted into a relative one, so it can be appended to the partitions base directory.
sevenautumns
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly refactors the
FileMounterto be more intuitive to use.