Dev/clone2 #133
Merged
Dev/clone2 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenautumns
force-pushed
the
dev/clone2
branch
from
9f233d8 to
6c7f714
Compare
dadada
reviewed
Nov 4, 2024
| | CloneFlags::CLONE_NEWNS | ||
| | CloneFlags::CLONE_NEWIPC | ||
| | CloneFlags::CLONE_NEWNET, | ||
| None, |
There was a problem hiding this comment.
We should think about tracking and reporting which child exited unexpectedly. Not for this PR, but in general. We could assign a new signal for each child.
dadada
approved these changes
Nov 4, 2024
clone3 requires an additional dependency and is fairly noisy to use. clone2 instead, makes the program more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.