chore: topics/k1ch/admin-delete-personas-roles/ add DB and API tests

database/test/db-admin-personaroles.test.js

@@ -116,4 +116,33 @@ describe('Admin persona roles view', () => {
       await usherDb('personas').where({ key: testPersonaKey }).del()
     })
   })
+
+  describe('Test Delete personas roles', () => {
+    let testPersonaKey
+    let validRoleKey
+    const invalidPersonaKey = 0
+
+    before(async () => {
+      const { key: roleKey } = await usherDb('roles').select('key').first()
+      validRoleKey = roleKey
+      const { key: tenantkey } = await usherDb('tenants').select('key').first()
+      const [persona] = await usherDb('personas').insert({ tenantkey, sub_claim: 'personarole@test' }).returning('key')
+      testPersonaKey = persona.key
+    })
+
+    it('Should return 0 when there is no personaroles record to delete', async () => {
+      const numberOfDeletedRecords = await adminPersonaRoles.deletePersonaRoleByKeys(invalidPersonaKey, validRoleKey)
+      assert.equal(numberOfDeletedRecords, 0)
+    })
+
+    it('Should return 1 when successfully deletes a personaroles record', async () => {
+      await usherDb('personaroles').insert({ personakey: testPersonaKey, rolekey: validRoleKey })
+      const numberOfDeletedRecords = await adminPersonaRoles.deletePersonaRoleByKeys(testPersonaKey, validRoleKey)
+      assert.equal(numberOfDeletedRecords, 1)
+    })
+
+    after(async () => {
+      await usherDb('personas').where({ key: testPersonaKey }).del()
+    })
+  })
 })

server/src/api_endpoints/personas/roles.js

@@ -39,7 +39,7 @@ const deletePersonaRole = async (req, res, next) => {
     ])
     await dbAdminPersonaRoles.deletePersonaRoleByKeys(personaKey, roleKey)
     res.status(204).send()
-} catch ({ httpStatusCode = 500, message }) {
+  } catch ({ httpStatusCode = 500, message }) {
     return next(createError(httpStatusCode, { message }))
   }
 }

server/test/endpoint_admin_personas_roles.test.js

@@ -151,6 +151,63 @@ describe('Admin Personas Roles', () => {
     })
   })
 
+  describe('DELETE:/personas/{persona_key}/roles/{role_key}', () => {
+    const deletePersonasRoles = async (roleKey, personaKey = testPersonaKey, header = requestHeaders) => {
+      return await fetch(`${url}/personas/${personaKey}/roles/${roleKey}`, {
+        method: 'DELETE',
+        headers: header,
+      })
+    }
+
+    it('should return 204, successful attempt to delete a persona role', async () => {
+      const response = await deletePersonasRoles(validRoleKey)
+      assert.equal(response.status, 204)
+    })
+
+    it('should return 204, delete a persona role successfully', async () => {
+      const [newPersonaRole] = await usherDb('personaroles')
+        .insert({ personakey: testPersonaKey, rolekey: validRoleKey }).returning('*')
+      assert.equal(newPersonaRole.personakey, testPersonaKey)
+      const response = await deletePersonasRoles(newPersonaRole.rolekey)
+      assert.equal(response.status, 204)
+      const personaRole = await usherDb('personaroles').select('*').where({ personakey: testPersonaKey, rolekey: validRoleKey })
+      assert.equal(personaRole.length, 0)
+    })
+
+    it('should return 400, two different invalid requests', async () => {
+      const [invalidRoleKeyResponse, invalidPersonaKeyResponse] = await Promise.all(
+        [
+          deletePersonasRoles('a'),
+          deletePersonasRoles(validRoleKey, 'a'),
+        ]
+      )
+      assert.equal([
+        invalidRoleKeyResponse.status,
+        invalidPersonaKeyResponse.status].every((status) => status === 400), true)
+    })
+
+    it('should return 401, unauthorized token', async () => {
+      const userAccessToken = await getTestUser1IdPToken()
+      const response = await deletePersonasRoles(
+        validRoleKey,
+        testPersonaKey,
+        {
+          ...requestHeaders,
+          Authorization: `Bearer ${userAccessToken}`
+        })
+      assert.equal(response.status, 401)
+    })
+
+    it('should return 404, fail to delete persona roles for an invalid persona', async () => {
+      const response = await deletePersonasRoles(validRoleKey, invalidPersona)
+      assert.equal(response.status, 404)
+    })
+
+    afterEach(async () => {
+      await usherDb('personaroles').where({ personakey: testPersonaKey }).del()
+    })
+  })
+
   after(async () => {
     await usherDb('personas').where({ key: testPersonaKey }).del()
   })