Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/k1ch/ internal caching for GET:/jwks.json #101

Closed
wants to merge 1 commit into from

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Mar 4, 2024

Overview

Enables internal caching for GET:/jwks.json to limit the number of DB connection within 60 seconds.

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Closes #

Open Questions or Items to Callout

@k1ch k1ch self-assigned this Mar 4, 2024
@k1ch k1ch added the enhancement New feature or request label Mar 4, 2024
@k1ch k1ch requested a review from mikelax March 4, 2024 20:39
@k1ch k1ch marked this pull request as draft March 15, 2024 16:28
@k1ch
Copy link
Collaborator Author

k1ch commented Apr 8, 2024

Closing this PR while we consider other approaches to enhance. In our use case, we enabled caching for GET:/jwks.json on AWS API Gateway.

@k1ch k1ch closed this Apr 8, 2024
@k1ch k1ch deleted the topic/k1ch/cache-get-jwks branch April 8, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant