Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic /k1ch/ Introduce API POST: clients/{client_id}/permissions #129

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Oct 30, 2024

Overview

Remaning:

  1. Additional tests
  2. Refactor error objects

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Partially completes #110
Partially completes #112

Open Questions or Items to Callout

@k1ch k1ch self-assigned this Oct 30, 2024
@k1ch k1ch added the component: admin Administration related functionality label Oct 30, 2024
@k1ch k1ch changed the title Topic /k1ch/ Introduce API POST: /permissions Topic /k1ch/ Introduce API POST: clients/{client_id}/permissions Oct 31, 2024
@k1ch k1ch force-pushed the topic/k1ch/post-permissions-api branch from 544b4bb to b87c64c Compare October 31, 2024 21:11
@k1ch k1ch marked this pull request as ready for review November 1, 2024 18:23
@k1ch k1ch requested a review from mikelax November 1, 2024 18:23
@k1ch k1ch merged commit ae1665d into main Nov 1, 2024
4 checks passed
@k1ch k1ch deleted the topic/k1ch/post-permissions-api branch November 1, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: admin Administration related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants