Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic /k1ch/ introduce API PUT:/roles/{role_key}/permissions #132

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Topic /k1ch/ introduce API PUT:/roles/{role_key}/permissions #132

merged 4 commits into from
Nov 10, 2024

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Nov 7, 2024 •
edited
Loading

Overview

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Partially completes #106

Open Questions or Items to Callout

@k1ch k1ch self-assigned this Nov 7, 2024
@k1ch k1ch force-pushed the topic/k1ch/put-roles-permissions branch 2 times, most recently from b25c382 to 0d051b0 Compare November 8, 2024 22:30
@k1ch k1ch force-pushed the topic/k1ch/put-roles-permissions branch from 0d051b0 to b8ccfd9 Compare November 8, 2024 22:33
@k1ch k1ch added the component: admin Administration related functionality label Nov 8, 2024
@k1ch k1ch requested a review from mikelax November 8, 2024 22:34
@k1ch k1ch marked this pull request as ready for review November 8, 2024 22:34
mikelax
mikelax approved these changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job @k1ch :shipit:

@k1ch k1ch merged commit 6f13db9 into main Nov 10, 2024
4 checks passed
@k1ch k1ch deleted the topic/k1ch/put-roles-permissions branch November 10, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikelax mikelax mikelax approved these changes

Assignees

@k1ch k1ch

Labels
component: admin Administration related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k1ch @mikelax