Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic / k1ch / Introduce GET:/permissions and GET:/clients/{client_id}/permissions APIs #135

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Dec 19, 2024

Overview

Open API Spec updates Image 1 Image 2

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Partially completes #110

Open Questions or Items to Callout

@k1ch k1ch self-assigned this Dec 19, 2024
@k1ch k1ch marked this pull request as draft December 19, 2024 23:17
@k1ch
Copy link
Collaborator Author

k1ch commented Dec 19, 2024

@mikelax For roles, we have both GET:/roles and GET:/clients/{client_id}/roles. Should we introduce both APIs for permissions to stay consistent or Client Admin API is sufficient?
Introduced both GET:/permissions and GET:/clients/{client_id}/permissions

@k1ch k1ch changed the title Topic / k1ch / Introduce API GET:/permissions Topic / k1ch / Introduce GET:/permissions and GET:/clients/{client_id}/permissions APIs Dec 20, 2024
@mikelax
Copy link
Collaborator

mikelax commented Dec 20, 2024

@mikelax For roles, we have both GET:/roles and GET:/clients/{client_id}/roles. Should we introduce both APIs for permissions to stay consistent or Client Admin API is sufficient? Introduced both GET:/permissions and GET:/clients/{client_id}/permissions

Thanks @k1ch , I see you already implemented both URL paths, I think that makes sense to stay consistent. Hopefully its similar logic under the hood.

@k1ch k1ch force-pushed the topic/k1ch/get-permissions branch from e125472 to aec5cdd Compare December 21, 2024 00:17
@k1ch k1ch marked this pull request as ready for review December 21, 2024 00:34
@k1ch k1ch requested a review from mikelax December 21, 2024 00:34
@k1ch k1ch merged commit 34755fc into main Dec 23, 2024
4 checks passed
@k1ch k1ch deleted the topic/k1ch/get-permissions branch December 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants