Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain mock identity provider behavior, update script #78

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

plaurent
Copy link
Contributor

@plaurent plaurent commented Nov 6, 2023

Overview

This PR makes improvements to the Quickstart and to a related script to ensure that everything works for a new user interested in test-driving the Usher.

The current problem is that the server/scripts/get_idp_token_from_mockserver.sh script accesses the mock identity provider via host localhost:3002. Although an identity token is returned, the following steps won't work because (1) that host isn't whitelisted in The Usher's environment sample file, and (2) the identities in the test PostgreSQL database are not identified as authenticated using that host.

Summary of Proposed Changes

  • The get_idp_token_from_mockserver.sh script was fixed to invoke the identity provider using idp.dmgt.com.mock.localhost:3002 as the host, which is a whitelisted host
  • The Quickstart was updated to include a note to the effect that if the hostname idp.dmgt.com.mock.localhost is not recognized on the local network, it should be added to /etc/hosts.

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Open Questions or Items to Callout

N/A

@mikelax mikelax merged commit 8045065 into DMGT-TECH:main Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants