explain mock identity provider behavior, update script #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes improvements to the Quickstart and to a related script to ensure that everything works for a new user interested in test-driving the Usher.
The current problem is that the
server/scripts/get_idp_token_from_mockserver.sh
script accesses the mock identity provider via hostlocalhost:3002
. Although an identity token is returned, the following steps won't work because (1) that host isn't whitelisted in The Usher's environment sample file, and (2) the identities in the test PostgreSQL database are not identified as authenticated using that host.Summary of Proposed Changes
get_idp_token_from_mockserver.sh
script was fixed to invoke the identity provider usingidp.dmgt.com.mock.localhost:3002
as the host, which is a whitelisted hostidp.dmgt.com.mock.localhost
is not recognized on the local network, it should be added to/etc/hosts
.Your PR Checklist 🚨
❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .
Open Questions or Items to Callout
N/A