Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use dev deps for server project, remove unused libs #82

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

mikelax
Copy link
Collaborator

@mikelax mikelax commented Dec 28, 2023

Overview

  • Remove libs that are not needed in the server project.
  • Move testing related libs to dev dependencies.
  • In server tests, replace uuid external library with built-in crypto. randomUUID() function

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Closes #40

Open Questions or Items to Callout

@mikelax mikelax requested a review from k1ch December 28, 2023 18:46
@mikelax mikelax self-assigned this Dec 28, 2023
@mikelax mikelax merged commit e050fe0 into main Dec 28, 2023
4 checks passed
@mikelax mikelax deleted the topics/mh-40-devlibs branch December 28, 2023 18:57
@k1ch k1ch added the enhancement New feature or request label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor server libs to make use of devDependencies
2 participants