Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics/k1ch/ Admin DELETE:/personas/{persona_key} #90

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Jan 25, 2024

Overview

Added OAS:

image

Added Tests:

image

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Relates to #59

Open Questions or Items to Callout

@k1ch k1ch force-pushed the topics/k1ch/admin-delete-personas branch from 4a8b766 to f5ebb0c Compare January 25, 2024 23:27
@k1ch k1ch self-assigned this Jan 25, 2024
@k1ch k1ch requested a review from mikelax January 25, 2024 23:28
@k1ch k1ch marked this pull request as ready for review January 25, 2024 23:28
mikelax
mikelax previously approved these changes Jan 26, 2024
Copy link
Collaborator

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k1ch nice job on this and with covering the cascade delete tests.

server/the-usher-openapi-spec.yaml Outdated Show resolved Hide resolved
@mikelax
Copy link
Collaborator

mikelax commented Jan 26, 2024

@k1ch if you are going to make one more change for this PR per the comment above, at the same time do you want to resolve the code scanning items related to the useless imports?

@k1ch k1ch merged commit 2ddfd72 into main Jan 26, 2024
4 checks passed
@k1ch k1ch deleted the topics/k1ch/admin-delete-personas branch January 26, 2024 17:12
@k1ch k1ch added the component: admin Administration related functionality label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: admin Administration related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants