Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/k1ch/ Admin GET:/personas #91

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Feb 13, 2024

OAS changes:

image

Added tests:

image

Overview

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Relates to #59

Open Questions or Items to Callout

  • @mikelax do we need pagination functionality for this version, or can it be implemented as a minor update later? Also, assuming each persona object is approximately 1KB, do we even need pagination functionality? If the answer is yes, should the response be an object instead of an array to include metadata?
{
    "metadata": {
        "limit": 100,
        "total": 5000,
        "offset": 1,
    },
    "data": [
        {}
    ]
}

@k1ch k1ch self-assigned this Feb 13, 2024
@k1ch k1ch changed the title [WIP] topic/k1ch/ Admin GET:/personas?filter=tenantname:DMGT&sort=sub_claim&order=asc [WIP] topic/k1ch/ Admin GET:/personas Feb 13, 2024
@k1ch k1ch changed the title [WIP] topic/k1ch/ Admin GET:/personas Topic/k1ch/ Admin GET:/personas Feb 14, 2024
@k1ch k1ch marked this pull request as ready for review February 14, 2024 00:33
@k1ch k1ch requested a review from mikelax February 14, 2024 00:34
@k1ch k1ch added the component: admin Administration related functionality label Feb 14, 2024
Copy link
Collaborator

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k1ch looks good, I left a couple of small questions.

server/the-usher-openapi-spec.yaml Outdated Show resolved Hide resolved
server/src/api_endpoints/personas/utils.js Outdated Show resolved Hide resolved
database/layer/admin-persona.js Outdated Show resolved Hide resolved
@k1ch k1ch requested a review from mikelax February 15, 2024 20:20
@k1ch
Copy link
Collaborator Author

k1ch commented Feb 15, 2024

@k1ch looks good, I left a couple of small questions.

@mikelax please review the latest changes and let me have your thoughts on the open question.

@k1ch k1ch force-pushed the topics/k1ch/admin-get-personas branch from 8aa3c8d to 994b2d6 Compare February 15, 2024 21:38
@k1ch k1ch force-pushed the topics/k1ch/admin-get-personas branch from 994b2d6 to e839810 Compare February 15, 2024 21:58
@k1ch k1ch merged commit a2efa00 into main Feb 16, 2024
4 checks passed
@k1ch k1ch deleted the topics/k1ch/admin-get-personas branch February 16, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: admin Administration related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants