Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNTRACKED/k1ch/update-get-jwks/ use knex instead of PG pool #92

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Feb 14, 2024

Overview

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Closes #

Open Questions or Items to Callout

@k1ch k1ch self-assigned this Feb 14, 2024
@k1ch k1ch requested a review from mikelax February 14, 2024 01:03
@k1ch k1ch added the enhancement New feature or request label Feb 14, 2024
@k1ch k1ch force-pushed the UNTRACKED/k1ch/update-get-jwks branch from 15eab05 to b075e79 Compare February 14, 2024 16:09
mikelax
mikelax previously approved these changes Feb 14, 2024
Copy link
Collaborator

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k1ch this change looks good.
One question, should we continue the rest of the refactor in db-keys.js to migrate the remaining functions to use knex and then we can get rid of the direct usage of PGPool in this file?

@k1ch
Copy link
Collaborator Author

k1ch commented Feb 14, 2024

@k1ch this change looks good. One question, should we continue the rest of the refactor in db-keys.js to migrate the remaining functions to use knex and then we can get rid of the direct usage of PGPool in this file?

Sure @mikelax. Please review: chore: UNTRACKED/k1ch/update-get-jwks/ remove pg pool from db-keys.js

@k1ch k1ch requested a review from mikelax February 14, 2024 17:54
database/layer/db-keys.js Outdated Show resolved Hide resolved
@k1ch k1ch force-pushed the UNTRACKED/k1ch/update-get-jwks branch from 351ab64 to a6925bc Compare February 14, 2024 18:58
@k1ch k1ch merged commit e5eec27 into main Feb 15, 2024
4 checks passed
@k1ch k1ch deleted the UNTRACKED/k1ch/update-get-jwks branch February 15, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants