Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/k1ch/ support token generation for persona with permission and no role (#71) #98

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Topic/k1ch/ support token generation for persona with permission and no role (#71) #98

merged 1 commit into from
Feb 20, 2024

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Feb 20, 2024 •
edited
Loading

Overview

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Closes #71

Open Questions or Items to Callout

@k1ch k1ch self-assigned this Feb 20, 2024
@k1ch k1ch requested a review from mikelax February 20, 2024 22:37
@k1ch k1ch added enhancement New feature or request component: user General usage functionality (non admin) labels Feb 20, 2024
@k1ch k1ch added this to the v2.0.0 milestone Feb 20, 2024
mikelax
mikelax approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@k1ch k1ch merged commit 5d11fd0 into main Feb 20, 2024
4 checks passed
@k1ch k1ch deleted the topic/k1ch/issue-71 branch February 20, 2024 23:33
@k1ch k1ch mentioned this pull request Mar 14, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikelax mikelax mikelax approved these changes

Assignees

@k1ch k1ch

Labels
component: user General usage functionality (non admin) enhancement New feature or request
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Support Usher Tokens Generation for a User, who has permissions but no roles related to the client app
2 participants
@k1ch @mikelax