Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic/k1ch/ Introduce API - PUT:/clients/{client_id} #99

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Topic/k1ch/ Introduce API - PUT:/clients/{client_id} #99

merged 3 commits into from
Feb 23, 2024

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Feb 23, 2024 •
edited
Loading

Overview

Added tests:

image

OAS update:

image

## Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Closes #13

Open Questions or Items to Callout

@k1ch k1ch self-assigned this Feb 23, 2024
@k1ch k1ch added the component: admin Administration related functionality label Feb 23, 2024
@k1ch k1ch added this to the v2.0.0 milestone Feb 23, 2024
@k1ch k1ch changed the title Topic/k1ch/ Introduce API - PUT:/clients/{client_id} [WIP] Topic/k1ch/ Introduce API - PUT:/clients/{client_id} Feb 23, 2024
@k1ch k1ch changed the title [WIP] Topic/k1ch/ Introduce API - PUT:/clients/{client_id} Topic/k1ch/ Introduce API - PUT:/clients/{client_id} Feb 23, 2024
@k1ch k1ch marked this pull request as ready for review February 23, 2024 19:29
@k1ch k1ch requested a review from mikelax February 23, 2024 19:29
mikelax
mikelax previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k1ch looks good. I left one trivial question.

database/layer/admin-client.js Show resolved Hide resolved
@k1ch k1ch requested a review from mikelax February 23, 2024 21:01
@k1ch k1ch force-pushed the topic/k1ch/api-put-clients branch from 73b2dd0 to 9f32edd Compare February 23, 2024 21:09
mikelax
mikelax approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@k1ch k1ch merged commit f08f5d5 into main Feb 23, 2024
4 checks passed
@k1ch k1ch deleted the topic/k1ch/api-put-clients branch February 23, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikelax mikelax mikelax approved these changes

Assignees

@k1ch k1ch

Labels
component: admin Administration related functionality
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Implement Client Admin APIs - /clients
2 participants
@k1ch @mikelax