Add TCP transport support in libspdm #3024
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manojkiran Eda <[email protected]>
manojkiraneda
force-pushed
the
tcp_support
branch
from
eeb74d6 to
ece63af
Compare
jyao1
reviewed
Apr 7, 2025
|
|
||
| typedef struct { | ||
| uint16_t payload_length; | ||
| uint8_t reserved; |
jyao1
reviewed
Apr 7, 2025
| uint16_t payload_length; | ||
| uint8_t reserved; | ||
| uint8_t message_type; | ||
| } tcp_spdm_binding_header_t; |
There was a problem hiding this comment.
this is defined in spec. please move to industry standard header file.
Not here.
jyao1
reviewed
Apr 7, 2025
Comment on lines
+39
to
+41
| #define TCP_MESSAGE_TYPE_OUT_OF_SESSION 0x01 | ||
| #define TCP_MESSAGE_TYPE_IN_SESSION 0x02 | ||
| #define TCP_MESSAGE_TYPE_HANDSHAKE_REQUEST 0x03 |
There was a problem hiding this comment.
The definition is incorrect according to the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.