Skip to content

Feature: Proper type prettification #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 130 commits into from
May 10, 2025
Merged

Feature: Proper type prettification #110

merged 130 commits into from
May 10, 2025

Conversation

DNKpp
Copy link
Owner

@DNKpp DNKpp commented Apr 14, 2025

No description provided.

@DNKpp DNKpp added the enhancement New feature or request label Apr 14, 2025
Copy link

codacy-production bot commented Apr 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.93% (target: -1.00%) 96.81%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0ceb7c0) 1714 1704 99.42%
Head commit (ef2c1f8) 2447 (+733) 2410 (+706) 98.49% (-0.93%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#110) 908 879 96.81%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 92.18062% with 71 lines in your changes missing coverage. Please review.

Project coverage is 94.93%. Comparing base (0ceb7c0) to head (ef2c1f8).
Report is 130 commits behind head on development.

Files with missing lines Patch % Lines
...ude/mimic++/printing/type/NameParserReductions.hpp 89.44% 9 Missing and 25 partials ⚠️
include/mimic++/printing/type/NamePrintVisitor.hpp 81.19% 16 Missing and 6 partials ⚠️
include/mimic++/printing/type/NameParser.hpp 95.67% 1 Missing and 8 partials ⚠️
include/mimic++/printing/type/NameParserTokens.hpp 97.82% 2 Missing and 1 partial ⚠️
include/mimic++/utilities/Algorithm.hpp 93.75% 2 Missing ⚠️
include/mimic++/printing/type/PrintType.hpp 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #110      +/-   ##
===============================================
- Coverage        96.32%   94.93%   -1.40%     
===============================================
  Files               47       51       +4     
  Lines             1714     2447     +733     
  Branches           643      857     +214     
===============================================
+ Hits              1651     2323     +672     
- Misses              13       43      +30     
- Partials            50       81      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Apr 15, 2025

Pull Request Test Coverage Report for Build 14947451805

Details

  • 879 of 908 (96.81%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 98.488%

Changes Missing Coverage Covered Lines Changed/Added Lines %
include/mimic++/printing/type/NameParser.hpp 207 208 99.52%
include/mimic++/utilities/Algorithm.hpp 31 32 96.88%
include/mimic++/printing/type/NameParserTokens.hpp 136 138 98.55%
include/mimic++/printing/type/NameParserReductions.hpp 313 322 97.2%
include/mimic++/printing/type/NamePrintVisitor.hpp 101 117 86.32%
Totals Coverage Status
Change from base Build 14871794436: -0.9%
Covered Lines: 2410
Relevant Lines: 2447

💛 - Coveralls

@DNKpp DNKpp force-pushed the dev/TypeNameParser branch from e3a5574 to 8c50a8e Compare April 26, 2025 13:34
@DNKpp DNKpp force-pushed the dev/TypeNameParser branch from d6c7412 to 4b51460 Compare May 7, 2025 19:47
@DNKpp DNKpp merged commit ef2c1f8 into development May 10, 2025
39 of 42 checks passed
@DNKpp DNKpp deleted the dev/TypeNameParser branch May 10, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants