Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Incorrect author shown in filtered topics view immediately after a reply #1261

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Jan 29, 2025

Description of PR...

After a reply is posted, the author of the topic is shown incorrectly (it shows the reply author not the topic author).

This is due to topic object population/hydration in topic view and topic is cached with incorrect contentid. Once cache expires and topic is reloaded, topic is shown correctly.

Changes made

  • Corrects the population of the topic object

How did you test these updates?

Local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #1254

@johnhenley johnhenley added bug Something isn't working usability Issues with UI labels Jan 29, 2025
@johnhenley johnhenley added this to the 08.02.03 milestone Jan 29, 2025
@johnhenley johnhenley requested a review from WillStrohl January 29, 2025 23:09
@johnhenley johnhenley self-assigned this Jan 29, 2025
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit 8bab74c into DNNCommunity:dev Feb 6, 2025
1 check passed
@johnhenley johnhenley deleted the issues/filtertopics-1254 branch February 6, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working usability Issues with UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Filtered Topics View showing incorrect "started by" user
2 participants