Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Control Panel forum & group admin issues #1265

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

FIX: Control Panel forum & group admin issues #1265

wants to merge 1 commit into from

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Fix some control panel issues related to forum/group administration.

Changes made

  • Restructure forum loading to loop through groups then forums for groups using DAL2 objects (previously, stored procedures return simple list with empty forum for an empty group). This allows groups without any forums to be properly maintained.
  • Re-read forum to repopulate object after insert/update
  • Set defaults for DateCreated/DateUpdated for forum

How did you test these updates?

Local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #1264

@johnhenley johnhenley added bug Something isn't working administrator Affects module administration / module settings / control panel labels Feb 2, 2025
@johnhenley johnhenley added this to the 08.02.03 milestone Feb 2, 2025
@johnhenley johnhenley requested a review from WillStrohl February 2, 2025 20:32
@johnhenley johnhenley self-assigned this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl Awaiting requested review from WillStrohl

Assignees

@johnhenley johnhenley

Labels
administrator Affects module administration / module settings / control panel bug Something isn't working
Projects
None yet
Milestone
08.02.03
Development

Successfully merging this pull request may close these issues.

BUG: Control Panel issues
1 participant
@johnhenley