-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Valueless PVL Keyword Issues #5573
Conversation
The build and test suite have started for your pull request. View build logs for results. |
The build and test suite have started for your pull request. View build logs for results. |
The build and test suite have started for your pull request. View build logs for results. |
4 similar comments
The build and test suite have started for your pull request. View build logs for results. |
The build and test suite have started for your pull request. View build logs for results. |
The build and test suite have started for your pull request. View build logs for results. |
The build and test suite have started for your pull request. View build logs for results. |
All possible tests are passing on this PR. Other tests would need to have something in the data area or test data area updated. Here are the following tests that will have some data element updated:
|
The build and test suite have started for your pull request. View build logs for results. |
1 similar comment
The build and test suite have started for your pull request. View build logs for results. |
The build and test suite have started for your pull request. View build logs for results. |
Looks like this is failing some tests.
|
7d6dfba
to
5b3fe5b
Compare
@AustinSanders I have updates to test data for the failing ISIS tests |
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5573". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
@AustinSanders All the tests failing that are not currently failing on dev should be data area changes. Once this gets approved and merged I can get those tests updated |
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5573". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
Description
Account for valueless PVL keywords that are not reserved keywords. This change is to test how much of ISIS breaks when we account for valueless PVL keywords
Related Issue
#5566
How Has This Been Validated?
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: