Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.0.4 LTS Release Prep #5686

Merged
merged 29 commits into from
Nov 27, 2024
Merged

8.0.4 LTS Release Prep #5686

merged 29 commits into from
Nov 27, 2024

Conversation

chkim-usgs
Copy link
Contributor

@chkim-usgs chkim-usgs commented Nov 27, 2024 •
edited
Loading

Description

Changes for 8.0.4 LTS:

[8.0.4] - 2024-11-26

Added

  • Added HRSC support in socetlinescankeywords #5465

Changed

  • Skypt has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Issue: #5443
  • Noseam has been refactored to be callable; old Makefile test has been removed and replaced by a gtest. Issue: #5599
  • Explode has been refactored to be callable; old Makefile test has been removed and replaced by a gtest. Issue: #5557
  • Isisminer has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Issue: #5516
  • Algebra has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Issue: #5594
  • Photrim has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Issue: #5581
  • Bandtrim has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Issue: #5571
  • Modified kaguyasp2isis to work with new (detached) data #5436
  • Added jigsaw error message for csminit'd images without csm parameters#5486

Fixed

  • Fixed a bug in noproj.cpp which left a persisent lbl file after running noproj. #5577
  • Fixed a bug in PolygonTools in which the program exited before attempting to fix an invalid Polygon #5520
  • Fixed a bug in QVIEW where images would double load if loaded from the commandline #5505
  • Fixed CSMSerialNumber.trn typo #5485
  • Fixed CSMSerialNumber.trn to be PVL compliant #5484
  • Fixed hrsc2isis to support level 3 hrsc images #5497
  • Fixed gllssi2isis to support V1.1 data #5396
  • Fixed noseam bug where a debugging output statement was inadvertently left in noseam.cpp. Issue: 5660
  • Fixed jigsaw bugs in which RADIUS is handled incorrectly in the jigsaw gui and in the bundleout.txt file. Slightly modified the FunctionalTestJigsawBundleXYZ ctest accordingly. Issue: 5642
  • Fixed a bug in kaguyasp2isis that doesn't work for data with a detached label. #5568
  • Fixed FunctionalTestCamstatsDefaultParameters test by increasing the runtime speed #5459
  • Fixed PHOTOMET not accepting backplanes #5281
  • Fixed dstripe parallel test failing by converting tests to gtests #5613

Related Issue

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@amystamile-usgs @chkim-usgs
Adds HRSC support in socetlinescankeywords (DOI-USGS#5669)
0d0a019 
* Adds HRSC support in socetlinescankeywords

* Add test cube

* Fixed tests
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@artmathgirl @chkim-usgs
Converted skypt to a callable app. Converted existing Makefile tests …
974c3ad 
…to gtests. Removed existing Makefile tests. (DOI-USGS#5444)

* Converted skypt to a callable app. Converted existing makefile tests to gtest format and removed old makefile tests and data. Addresses DOI-USGS#5443.

* Updated contributor list to add Sarah S. Sutton. Addresses DOI-USGS#5443.

---------

Co-authored-by: Sarah Sutton <[email protected]>
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@kledmundson @chkim-usgs
Noseam has been refactored to be callable. Makefile test has been con…
71243c6 
…verted to a gtest and removed. (DOI-USGS#5600)

* Noseam has been refactored to be callable. Makefile test has been converted to a gtest and removed. Addresses DOI-USGS#5599.

* Modifications to address gtest failures. Also added addtional input parameter error checking to ensure noseam exits prior to generation of temporary files. Finally modified gtests to remove the print.prt file if generated. Addresses DOI-USGS#5599.
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

kledmundson and others added 2 commits November 27, 2024 08:46
@kledmundson @acpaquette @chkim-usgs
The explode application has been refactored to be callable and Makefi…
b85276b 
…le test converted to a gtest. (DOI-USGS#5590)

* Updated explode application gtest to use DefaultCube fixture instead of cube in isis/tests/data. Addresses DOI-USGS#5557.

* Cleaned up includes in default explode gtest. Added history entry to explode.xml. Addresses DOI-USGS#5557.

* Updating main.cpp and removed Makefile tests for explode conversion to callable app. Addresses DOI-USGS#5557.

* Added CHANGELOG entry for conversion of explode app to callable function. Addresses DOI-USGS#5557.

---------

Co-authored-by: Adam Paquette <[email protected]>
@kledmundson @chkim-usgs
Isisminer has been refactored to be callable and Makefile tests conve…
61ab3e7 
…rted to gtest format (DOI-USGS#5579)

* Fixed minor misspellings in error messages. Addresses DOI-USGS#5516.

* Test data added for isisminer. Addresses DOI-USGS#5516.

* Converted isisminer Makefile tests to gtest format. Addresses DOI-USGS#5516.

* Converted isisminer application to callable function. Addresses DOI-USGS#5516.

* Minor tweak to isisminer csvwriter test. Addresses DOI-USGS#5516.

* Added compareCsvLineCustomDelimiter method, specifically for isisminer testing support. Addresses DOI-USGS#5516.

* Removed isisminer Makefile tests (replaced by gtests) and updated CHANGELOG reflecting conversion of isisminer to callable app. Addresses DOI-USGS#5516.

* Replace isis cube in /isis/tests/data/isisminer/gistest with isd and label files. Minor tweaks to FunctionalTestsIsisminer.cpp. History entry added to isisminer.xml. Addresses DOI-USGS#5516.

* Minor changes for conversion of isisminer to callable app. Addresses DOI-USGS#5516.

* Had to add data file index.lbl to the .gitignore file for it to be uploaded. Addresses DOI-USGS#5516.
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

1 similar comment
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@kledmundson @chkim-usgs
Algebra has been refactored to be callable; old Makefile tests have b…
9ec93dc 
…een converted to gtests and removed. Addresses DOI-USGS#5594. (DOI-USGS#5597)
@kledmundson @chkim-usgs
Photrim has been refactored to be callable; old Makefile tests have b…
55b8b24 
…een converted to gtests and removed. (DOI-USGS#5582)

* Photrim has been converted to a callable app. Corresponding Makefile tests have been converted to gtests and removed. Addresses DOI-USGS#5581.

* Tweaks to FunctionalTestsPhotrim.cpp. Addresses DOI-USGS#5581.
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

1 similar comment
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@kledmundson @chkim-usgs
Bandtrim has been refactored to be callable; old Makefile tests have …
8535ea3 
…been converted to gtests. (DOI-USGS#5572)

* Bandtrim has been refactored to be callable; old Makefile tests have been removed and replaced by gtests. Addresses DOI-USGS#5571.

* Update FunctionalTestsBandtrim.cpp

Minor documentation change.
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@AustinSanders @chkim-usgs
Updated kaguyasp2ascii to support newer (detached) data (DOI-USGS#5568)
ca4a0fa 
* Modified to work with new (detached) data

* Updated changelog

* Allow data specification outside current directory
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@AustinSanders @chkim-usgs
Jigsaw csm error message (DOI-USGS#5562)
85e06d4 
* Added fail-early + error message for csminit'd images without csm solve parameters

* Updated changelog
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@kledmundson @chkim-usgs
Bug fix in noproj to remove persistent temporary lbl file (DOI-USGS#5578
73a5035 
)

* Added line to close match cube in noproj.cpp. Not closing the cube resulted in a temporary "*.lbl" file that remained after running the noproj application. Addresses DOI-USGS#5577.

* CHANGELOG entry for noproj bug fix. Addresses DOI-USGS#5577.

* Added history entry in noproj.xml. Addresses DOI-USGS#5577.
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@AustinSanders @chkim-usgs
Remove restrictive validity check in caminfo (DOI-USGS#5553)
66e650d 
* Removed preemptive validity check for polygon

* Removed unused import

* Updated changelog
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@acpaquette @chkim-usgs
Qview command line Fix (DOI-USGS#5505)
459f9d4 
* Avoid double image load when opening cubes from cmdline in qview

* Added changelog entry

* Revert interval change
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

1 similar comment
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@amystamile-usgs @chkim-usgs
CsmSerialNumber.trn - typo and PVL compilant fix (DOI-USGS#5561)
aba3780 
* Fixed typo

* PVL compliant

* PR feedback changes
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@amystamile-usgs @chkim-usgs
hrsc2isis support for level 3 images (DOI-USGS#5560)
c8cf261 
* Remove label check for level3

* update changelog

* fix test

* addressed PR feedback

* fixed grammar
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@kledmundson @chkim-usgs
Bug fixes to address incorrect handling of RADIUS in the jigsaw GUI a…
ea55b9e 
…nd in the bundleout.txt file when performing a rectangular (XYZ) bundle adjustment, originally implemented in UofA OSIRIS-REx code on 2019-07-30. Addresses DOI-USGS#5642. (DOI-USGS#5643)

* The RADIUS checkbox in the GUI is excluded when a RECTANGULAR solution is selected.

* In the bundleout.txt file, for rectangular solutions, 1) RADIUS is set to N/A in the SOLVE OPTIONS section; and 2) the POINTS UNCERTAINTY SECTION was fixed to properly display adjusted point uncertainty statistics with Error Propagation turned on.

* Spacing for point labels was cleaned up in the INPUT: GLOBAL IMAGE PARAMETER UNCERTAINTIES section.

* Finally, a slight modification was added to the FunctionalTestJigsawBundleXYZ ctest to verify that RADIUS is N/A in a RECTANGULAR solution.
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@murashinln @chkim-usgs
Updated kaguyasp2ascii to support newer (detached) data (DOI-USGS#5568)
5397b32 
* Modified to work with new (detached) data

* Updated changelog

* Allow data specification outside current directory
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@amystamile-usgs @chkim-usgs
fixes photomet not accepting backplanes (DOI-USGS#5658)
0d3e1f9 
* fixes photomet not accepting backplanes

* fix changelog

* Converted to gtests

* Add input cube attributes
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@amystamile-usgs @chkim-usgs
Convert dstripe to gtests (DOI-USGS#5665)
2b9fd34 
* Convert dstripe to gtests

* add changelog

* Fixed build error
@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@github-actions GitHub Actions
Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5686".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@Kelvinrr Kelvinrr merged commit ae7eccf into DOI-USGS:8.0 Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chkim-usgs @Kelvinrr @amystamile-usgs @artmathgirl @kledmundson @AustinSanders @acpaquette @murashinln