Skip to content

Add endpoint to fetch submissions by internal ID for domlogo #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nickygerritsen
Copy link
Member

No description provided.

@nickygerritsen nickygerritsen requested a review from meisterT May 23, 2025 20:56
@nickygerritsen
Copy link
Member Author

The other alternatives are:

  • Add an endpoint that converts the external submission ID to the internal submission ID.
  • Add the internal submission ID to the Working directory: line in the judgedaemon.

@vmcj
Copy link
Member

vmcj commented May 24, 2025

Why do we actually get this problem? I would prefer not exposing our "internal" id anywhere.

So I think option1 is better, or making sure our internal ID is also the external ID, to remove such doublings.

@nickygerritsen
Copy link
Member Author

nickygerritsen commented Jul 4, 2025

Another option is to use external ID's in the folder structure on the server, then it automatically works.

I remember we had a discussion we didn't want this, but I'm not sure why anymore.

@vmcj
Copy link
Member

vmcj commented Jul 4, 2025

I think domlogo.py should work mostly as "external tool", so I would prefer that the judgedaemon only exposes parts as external to stay in line. So I think we should reconsider that we just use the externalid.

But @meisterT / @eldering might know what was this discussion?

@meisterT
Copy link
Member

meisterT commented Jul 4, 2025

Is there any limitation on the character set of external IDs?

@nickygerritsen
Copy link
Member Author

Is there any limitation on the character set of external IDs?

[a-zA-Z0-9_.-] of length at most 36 and not starting with a - (dash) or . (dot) or ending with a . (dot)

Sounds like we can use them as folder names easily.

@nickygerritsen
Copy link
Member Author

After discussing IRL we will move to using external IDs in the judgehost API. I will implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants