Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depcheck action workflow #1067

Merged
merged 10 commits into from
Jan 1, 2024
Merged

depcheck action workflow #1067

merged 10 commits into from
Jan 1, 2024

Conversation

prishavall
Copy link
Contributor

Github Issue: #869

We have instances where we install a frontend library with yarn, but then we don't actually end up using it in our code. We should try to keep our frontend package size as small as possible and keep only the essentials to make our builds run faster

It provides a new command npx dep-check to see if there are any unused dependencies

Testing Methodology
Ran it through the front-end directory

@prishavall prishavall requested a review from a team as a code owner November 29, 2023 01:26
@prishavall prishavall added the devops DevOps tasks label Nov 29, 2023
Copy link
Contributor

sweep-ai bot commented Nov 29, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment

package.json Outdated Show resolved Hide resolved
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

.github/workflows/node.js.yml Outdated Show resolved Hide resolved
@karkir0003
Copy link
Member

@farisdurrani are the package.json files correctly updated? @prishavall needed to add depcheck as a dev dependency?

@karkir0003 karkir0003 linked an issue Nov 29, 2023 that may be closed by this pull request
@farisdurrani
Copy link
Member

Yes, it's more apt to put in devDep since it's not a critical functionality for the app

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwu359 @farisdurrani added another comment

.github/workflows/node.js.yml Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@karkir0003 karkir0003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job on this :)

@farisdurrani
Copy link
Member

Lgtm

@prishavall prishavall added this pull request to the merge queue Jan 1, 2024
Merged via the queue into nextjs with commit 910a478 Jan 1, 2024
9 checks passed
@prishavall prishavall deleted the depcheck-action branch January 1, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops DevOps tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

depcheck github action
4 participants