-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depcheck action workflow #1067
depcheck action workflow #1067
Conversation
Apply Sweep Rules to your PR?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@farisdurrani are the package.json files correctly updated? @prishavall needed to add depcheck as a dev dependency? |
Yes, it's more apt to put in devDep since it's not a critical functionality for the app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwu359 @farisdurrani added another comment
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job on this :)
Lgtm |
Github Issue: #869
We have instances where we install a frontend library with yarn, but then we don't actually end up using it in our code. We should try to keep our frontend package size as small as possible and keep only the essentials to make our builds run faster
It provides a new command npx dep-check to see if there are any unused dependencies
Testing Methodology
Ran it through the front-end directory