-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend Buildcheck Workflow Revamp #1099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please fix build errors @prishavall |
karkir0003
reviewed
Jan 17, 2024
karkir0003
reviewed
Jan 17, 2024
karkir0003
reviewed
Jan 17, 2024
farisdurrani
approved these changes
Feb 2, 2024
Apologies for the delay, @prishavall . I'm okay with the changes and I'll merge this in for you |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend Buildcheck Workflow Revamp
#1086
What user problem are we solving?
Creating a unified Frontend build check workflow to ensure code quality and consistency
What solution does this PR provide?
This creates the build check along with pnpm features and a specific working directory point to the frontend
Testing Methodology