hotfix: api path 수정

DSM-Repo · Sep 8, 2024 · 3b1cf80 · 3b1cf80
1 parent 14365c9
commit 3b1cf80
Show file tree

Hide file tree

Showing 6 changed files with 47 additions and 44 deletions.
diff --git a/src/main/java/com/repo/whopper/interfaces/feedback/FeedbackController.java b/src/main/java/com/repo/whopper/interfaces/feedback/FeedbackController.java
@@ -19,7 +19,7 @@
 @RestController
 @RequiredArgsConstructor
 @RequestMapping("/feedback")
-public class FeedbackController {
+class FeedbackController {
     private final AddFeedbackUseCase addFeedbackUseCase;
     private final AcceptFeedbackUseCase acceptFeedbackUseCase;
     private final RejectFeedbackUseCase rejectFeedbackUseCase;
@@ -30,57 +30,56 @@ public class FeedbackController {
 
     @OnlyStudent
     @PostMapping("/confirm")
-    public void confirm(@RequestBody IdRequest request) {
-        confirmFeedbackUseCase.confirm(request.id);
+    void confirm(@RequestParam String id) {
+        confirmFeedbackUseCase.confirm(id);
     }
 
     @OnlyTeacher
     @PostMapping("/accept")
-    public void accept(@RequestBody IdRequest request) {
-        acceptFeedbackUseCase.accept(request.id);
+    void accept(@RequestParam String id) {
+        acceptFeedbackUseCase.accept(id);
     }
 
     @OnlyTeacher
     @PostMapping("/reject")
-    public void reject(@RequestBody IdRequest request) {
-        rejectFeedbackUseCase.reject(request.id);
+    void reject(@RequestParam String id) {
+        rejectFeedbackUseCase.reject(id);
     }
 
     @OnlyStudent
     @GetMapping
-    public DataResponseInfo<FeedbackResponse.StudentResponse> getMyFeedbackList() {
+    DataResponseInfo<FeedbackResponse.StudentResponse> getMyFeedbackList() {
         return findFeedbackUseCase.getCurrentStudentFeedbackList();
     }
 
     @OnlyTeacher
     @GetMapping("/{resumeId}")
-    public DataResponseInfo<FeedbackResponse.TeacherResponse> getFeedbackListByResumeId(@PathVariable String resumeId) {
+    DataResponseInfo<FeedbackResponse.TeacherResponse> getFeedbackListByResumeId(@PathVariable String resumeId) {
         return findFeedbackUseCase.getFeedbackListByResumeId(resumeId);
     }
 
     @OnlyTeacher
     @GetMapping("/teacher")
-    public DataResponseInfo<FeedbackResponse.TeacherResponse> getFeedbacksWrittenByTeacher() {
+    DataResponseInfo<FeedbackResponse.TeacherResponse> getFeedbacksWrittenByTeacher() {
         return findFeedbackUseCase.getFeedbacksWrittenByTeacher();
     }
 
     @OnlyTeacher
     @PostMapping
-    public void addFeedback(@RequestBody FeedbackRequest request) {
+    void addFeedback(@RequestBody FeedbackRequest request) {
         addFeedbackUseCase.addFeedback(request);
     }
 
     @OnlyTeacher
     @PatchMapping("/{feedbackId}")
-    public void updateFeedback(@PathVariable String feedbackId, @RequestBody UpdateFeedbackRequest request) {
+    void updateFeedback(@PathVariable String feedbackId, @RequestBody UpdateFeedbackRequest request) {
         updateFeedbackUseCase.updateFeedback(feedbackId, request);
     }
 
     @OnlyTeacher
-    @DeleteMapping
-    public void deleteFeedback(@RequestBody IdRequest request) {
-        deleteFeedbackUseCase.deleteFeedback(request.id());
+    @DeleteMapping("/{feedbackId}")
+    void deleteFeedback(@PathVariable String feedbackId) {
+        deleteFeedbackUseCase.deleteFeedback(feedbackId);
     }
 
-    record IdRequest(String id) {}
 }
diff --git a/src/main/java/com/repo/whopper/interfaces/file/FileController.java b/src/main/java/com/repo/whopper/interfaces/file/FileController.java
@@ -13,23 +13,22 @@
 @RestController
 @RequiredArgsConstructor
 @RequestMapping("/file")
-public class FileController {
+class FileController {
     private final ImageUseCase imageUseCase;
 
     @OnlyStudent
     @PostMapping(value = "/image", consumes = {
             MediaType.MULTIPART_FORM_DATA_VALUE
     })
-    public ImagePathResponse uploadImage(@RequestPart("file") MultipartFile filePart, @RequestParam("type") ImageType imageType) {
+    ImagePathResponse uploadImage(@RequestPart("file") MultipartFile filePart, @RequestParam("type") ImageType imageType) {
         String path = imageUseCase.saveImage(filePart, imageType);
         return new ImagePathResponse(imageUseCase.getFileBaseUrl() + path, filePart.getOriginalFilename());
     }
 
-    @DeleteMapping
+    @DeleteMapping("/{url}")
     @ResponseStatus(HttpStatus.NO_CONTENT)
-    void deleteImage(@RequestBody UrlRequest request) {
-        imageUseCase.deleteImage(request.url);
+    void deleteImage(@PathVariable String url) {
+        imageUseCase.deleteImage(url);
     }
 
-    record UrlRequest(String url) {}
 }
diff --git a/src/main/java/com/repo/whopper/interfaces/history/HistoryController.java b/src/main/java/com/repo/whopper/interfaces/history/HistoryController.java
@@ -34,11 +34,10 @@ void create(@RequestBody CreateHistoryRequest request) {
     }
 
     @OnlyTeacher
-    @DeleteMapping
-    void deleteById(@RequestBody DeleteHistoryRequest request) {
-        deleteHistoryUseCase.deleteById(request.id());
+    @DeleteMapping("/{historyId}")
+    void deleteById(@PathVariable String historyId) {
+        deleteHistoryUseCase.deleteById(historyId);
     }
 
-    record DeleteHistoryRequest(String id) {}
     record CreateHistoryRequest(String date, String content) {}
 }
diff --git a/src/main/java/com/repo/whopper/interfaces/library/LibraryController.java b/src/main/java/com/repo/whopper/interfaces/library/LibraryController.java
@@ -17,14 +17,14 @@
 @RestController
 @RequiredArgsConstructor
 @RequestMapping("/library")
-public class LibraryController {
+class LibraryController {
     private final CreateLibraryUseCase createLibraryUseCase;
     private final PdfUseCase pdfUseCase;
     private final ChangeLibraryAccessRightUseCase changeLibraryAccessRightUseCase;
     private final FindLibraryUseCase findLibraryUseCase;
 
     @PostMapping
-    public void saveLibraryresume(
+    void saveLibraryresume(
             @RequestParam(name = "grade") Integer grade,
             @RequestPart(name = "pdf") MultipartFile pdfPart,
             @RequestPart(name = "index") ResumeIndexRequest indexPart
@@ -34,25 +34,27 @@ public void saveLibraryresume(
     }
 
     @GetMapping("/{libraryId}")
-    public LibraryDetailResponse getLibraryDetailResponse(@PathVariable String libraryId) {
+    LibraryDetailResponse getLibraryDetailResponse(@PathVariable String libraryId) {
         return findLibraryUseCase.findLibraryDetail(libraryId);
     }
 
     @GetMapping
-    public DataResponseInfo<LibraryResponse> studentFindLibrary(@RequestParam(defaultValue = "0") Integer year) {
+    DataResponseInfo<LibraryResponse> studentFindLibrary(@RequestParam(defaultValue = "0") Integer year) {
         return findLibraryUseCase.findLibrary(year);
     }
 
     @OnlyTeacher
-    @PatchMapping("/access-right")
-    public void changeLibraryAccessRight(@RequestBody AccessRightRequest request) {
-        changeLibraryAccessRightUseCase.changeLibraryAccessRight(request.libraryId(), request.accessRight());
+    @PatchMapping("/{libraryId}")
+    void changeLibraryAccessRight(
+            @PathVariable String libraryId,
+            @RequestParam(name = "access-right") LibraryElementDto.AccessRight accessRight
+    ) {
+        changeLibraryAccessRightUseCase.changeLibraryAccessRight(libraryId, accessRight);
     }
 
     @GetMapping("/{libraryId}/public")
-    public LibraryDetailResponse findLibraryDetail(@PathVariable String libraryId) {
+    LibraryDetailResponse findLibraryDetail(@PathVariable String libraryId) {
         return findLibraryUseCase.findLibraryDetail(libraryId);
     }
 
-    record AccessRightRequest(String libraryId, LibraryElementDto.AccessRight accessRight) {}
 }
diff --git a/src/main/java/com/repo/whopper/interfaces/major/MajorController.java b/src/main/java/com/repo/whopper/interfaces/major/MajorController.java
@@ -9,33 +9,37 @@
 import lombok.RequiredArgsConstructor;
 import org.springframework.web.bind.annotation.*;
 
+import java.net.URLDecoder;
+import java.nio.charset.StandardCharsets;
 import java.util.List;
 
 @RestController
 @RequiredArgsConstructor
 @RequestMapping("/major")
-public class MajorController {
+class MajorController {
     private final AddMajorUseCase addMajorUseCase;
     private final FindMajorUseCase findMajorUseCase;
     private final DeleteMajorUseCase deleteMajorUseCase;
 
     @OnlyTeacher
     @PostMapping
-    public void add(@RequestBody AddMajorRequest request) {
+    void add(@RequestBody AddMajorRequest request) {
         addMajorUseCase.add(request.majors());
     }
 
     @GetMapping
-    public DataResponseInfo<MajorModel> findAll() {
+    DataResponseInfo<MajorModel> findAll() {
         return findMajorUseCase.findAll();
     }
 
     @OnlyTeacher
-    @DeleteMapping
-    public void delete(@RequestBody DeleteMajorRequest request) {
-        deleteMajorUseCase.delete(request.name);
+    @DeleteMapping("/{name}")
+    void delete(@PathVariable String name)  {
+        final var decodedName = URLDecoder.decode(name, StandardCharsets.UTF_8);
+        final var replacedName = decodedName.replace("_", " ");
+
+        deleteMajorUseCase.delete(replacedName);
     }
 
     private record AddMajorRequest(List<String> majors) {}
-    private record DeleteMajorRequest(String name) {}
 }
diff --git a/src/main/java/com/repo/whopper/interfaces/student/StudentController.java b/src/main/java/com/repo/whopper/interfaces/student/StudentController.java
@@ -11,12 +11,12 @@
 @RestController
 @RequestMapping("/user")
 @RequiredArgsConstructor
-public class StudentController {
+class StudentController {
     private final GetCurrentUserInfoUseCase getCurrentUserInfoUseCase;
 
     @OnlyStudent
     @GetMapping("/current/info")
-    public GetCurrentUserInfoResponse getCurrentUserInfoResponse() {
+    GetCurrentUserInfoResponse getCurrentUserInfoResponse() {
         return getCurrentUserInfoUseCase.get();
     }
 }