Skip to content

Commit

Permalink
hotfix: Transactional 어노테이션 추가 및 전공 수정
Browse files Browse the repository at this point in the history
  • Loading branch information
ori0o0p committed Aug 19, 2024
1 parent 613c59f commit 69cdf69
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@
import com.example.whopper.domain.document.exception.DocumentModificationException;
import com.example.whopper.global.utils.current.CurrentStudent;
import lombok.RequiredArgsConstructor;
import org.springframework.transaction.annotation.Transactional;

@RequiredArgsConstructor
public abstract class AbstractUpdateElementServiceBase<T> {
protected final DocumentRepository documentRepository;
protected final CurrentStudent currentStudent;

@Transactional
public void update(T request) {
var document = currentStudent.getDocument();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@
import com.example.whopper.global.utils.DataResponseInfo;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

@Service
@RequiredArgsConstructor
@Transactional(readOnly = true)
public class FindDocumentService implements FindDocumentUseCase {
private final DocumentRepository documentRepository;
private final FeedbackMongoRepository feedbackMongoRepository;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@
import com.example.whopper.domain.feedback.dao.FeedbackMongoRepository;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

@Service
@Transactional
@RequiredArgsConstructor
public class ReleaseDocumentService implements ReleaseDocumentUseCase {
private final DocumentRepository documentRepository;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
import com.example.whopper.global.utils.current.CurrentStudent;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

@Service
@Transactional
@RequiredArgsConstructor
public class SubmitMyDocumentService implements SubmitMyDocumentUseCase {
private final DocumentRepository documentRepository;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,8 @@ public void saveAll(List<MajorEntity> entities) {
}

@Override
public MajorEntity getById(String majorId) {
return findById(majorId)
.orElse(null);
}

@Override
public Optional<MajorEntity> findById(String majorId) {
return majorMongoRepository.findById(majorId);
public Optional<MajorEntity> findByName(String name) {
return majorMongoRepository.findByName(name);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
import com.example.whopper.domain.major.domain.MajorEntity;
import org.springframework.data.mongodb.repository.MongoRepository;

import java.util.Optional;

public interface MajorMongoRepository extends MongoRepository<MajorEntity, String> {
boolean existsByName(String name);
Optional<MajorEntity> findByName(String name);
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
public interface MajorRepository {
MajorEntity save(MajorEntity entity);
void saveAll(List<MajorEntity> entities);
MajorEntity getById(String majorId);
Optional<MajorEntity> findById(String majorId);
Optional<MajorEntity> findByName(String name);
List<MajorEntity> findAll();
void delete(MajorEntity entity);
boolean existsByName(String name);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class DefaultMajorFacade {
private final MajorRepository majorRepository;

public MajorEntity getDefaultMajor() {
return majorRepository.findById(defaultMajorProperties.majorId())
return majorRepository.findByName(defaultMajorProperties.name())
.orElseGet(() -> majorRepository.save(MajorEntity.createEntity(defaultMajorProperties.name())));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,18 @@

import lombok.Getter;
import org.springframework.data.annotation.Id;
import org.springframework.data.mongodb.core.index.Indexed;
import org.springframework.data.mongodb.core.mapping.Document;
import org.springframework.data.mongodb.core.mapping.Field;
import org.springframework.data.mongodb.core.mapping.MongoId;

@Getter
@Document(collection = "majors")
public class MajorEntity {
@Id
private String id;
@Field("name")
@Indexed(unique = true)
private String name;

protected MajorEntity() {}
Expand Down

0 comments on commit 69cdf69

Please sign in to comment.