Enable noImplicitOverride and moduleDetection; fix test type checking

DallasHoff · Aug 8, 2024 · 8031caa · 8031caa
1 parent 00269dc
commit 8031caa
Show file tree

Hide file tree

Showing 21 changed files with 37 additions and 28 deletions.
diff --git a/package.json b/package.json
@@ -28,7 +28,7 @@
 		"src"
 	],
 	"scripts": {
-		"build": "tsc",
+		"build": "tsc --project tsconfig.build.json",
 		"test": "vitest",
 		"test:ui": "vitest --ui",
 		"format": "prettier . --write",

diff --git a/src/client.ts b/src/client.ts
@@ -162,8 +162,8 @@ export class SQLocal {
 		};
 
 		if (message.type === 'data') {
-			data.rows = message.data[0].rows;
-			data.columns = message.data[0].columns;
+			data.rows = message.data[0]?.rows ?? [];
+			data.columns = message.data[0]?.columns ?? [];
 		}
 
 		return data;

diff --git a/src/lib/exec-on-db.ts b/src/lib/exec-on-db.ts
@@ -21,7 +21,7 @@ export function execOnDb(
 		case 'run':
 			break;
 		case 'get':
-			statementData.rows = rows[0];
+			statementData.rows = rows[0] ?? [];
 			break;
 		case 'all':
 		default:

diff --git a/test/batch.test.ts b/test/batch.test.ts
@@ -1,5 +1,5 @@
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { SQLocal } from '../src/index';
+import { SQLocal } from '../src/index.js';
 
 describe('batch', () => {
 	const { sql, batch } = new SQLocal('batch-test.sqlite3');

diff --git a/test/create-callback-function.test.ts b/test/create-callback-function.test.ts
@@ -1,5 +1,5 @@
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { SQLocal } from '../src/index';
+import { SQLocal } from '../src/index.js';
 
 describe('createCallbackFunction', () => {
 	const { sql, createCallbackFunction } = new SQLocal(

diff --git a/test/create-scalar-function.test.ts b/test/create-scalar-function.test.ts
@@ -1,5 +1,5 @@
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { SQLocal } from '../src/index';
+import { SQLocal } from '../src/index.js';
 
 describe('createScalarFunction', () => {
 	const { sql, createScalarFunction } = new SQLocal(

diff --git a/test/destroy.test.ts b/test/destroy.test.ts
@@ -1,5 +1,5 @@
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { SQLocal } from '../src/index';
+import { SQLocal } from '../src/index.js';
 
 describe('destroy', () => {
 	const { sql, destroy } = new SQLocal('destroy-test.sqlite3');

diff --git a/test/drizzle/driver.test.ts b/test/drizzle/driver.test.ts
@@ -1,9 +1,9 @@
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { SQLocalDrizzle } from '../../src/drizzle';
+import { SQLocalDrizzle } from '../../src/drizzle/index.js';
 import { drizzle } from 'drizzle-orm/sqlite-proxy';
 import { int, real, sqliteTable, text } from 'drizzle-orm/sqlite-core';
 import { desc, eq, relations, sql as dsql } from 'drizzle-orm';
-import { sleep } from '../test-utils/sleep';
+import { sleep } from '../test-utils/sleep.js';
 
 describe('drizzle driver', () => {
 	const { sql, driver, batchDriver, transaction } = new SQLocalDrizzle(

diff --git a/test/get-database-file.test.ts b/test/get-database-file.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it } from 'vitest';
-import { SQLocal } from '../src/index';
+import { SQLocal } from '../src/index.js';
 
 describe('getDatabaseFile', () => {
 	const fileName = 'get-database-file-test.sqlite3';

diff --git a/test/get-database-info.test.ts b/test/get-database-info.test.ts
@@ -1,5 +1,5 @@
 import { afterEach, describe, expect, it } from 'vitest';
-import { SQLocal } from '../src/index';
+import { SQLocal } from '../src/index.js';
 
 describe('getDatabaseInfo', () => {
 	const { sql, getDatabaseInfo } = new SQLocal(

diff --git a/test/init.test.ts b/test/init.test.ts
@@ -1,5 +1,5 @@
 import { afterAll, afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { SQLocal } from '../src/index';
+import { SQLocal } from '../src/index.js';
 
 describe('init', () => {
 	const databasePath = 'init-test.sqlite3';

diff --git a/test/kysely/dialect.test.ts b/test/kysely/dialect.test.ts
@@ -1,8 +1,9 @@
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { Generated, Kysely, ParseJSONResultsPlugin } from 'kysely';
+import { Kysely, ParseJSONResultsPlugin } from 'kysely';
+import type { Generated } from 'kysely';
 import { jsonArrayFrom } from 'kysely/helpers/sqlite';
-import { SQLocalKysely } from '../../src/kysely';
-import { sleep } from '../test-utils/sleep';
+import { SQLocalKysely } from '../../src/kysely/index.js';
+import { sleep } from '../test-utils/sleep.js';
 
 describe('kysely dialect', () => {
 	const { dialect, transaction } = new SQLocalKysely(

diff --git a/test/kysely/migrations.test.ts b/test/kysely/migrations.test.ts
@@ -1,5 +1,5 @@
 import { afterEach, describe, expect, it } from 'vitest';
-import { SQLocalKysely } from '../../src/kysely';
+import { SQLocalKysely } from '../../src/kysely/index.js';
 import { Kysely, Migrator } from 'kysely';
 
 describe('kysely migrations', () => {
@@ -11,7 +11,7 @@ describe('kysely migrations', () => {
 		db,
 		provider: {
 			async getMigrations() {
-				const { migrations } = await import('./migrations/');
+				const { migrations } = await import('./migrations/index.js');
 				return migrations;
 			},
 		},

diff --git a/test/kysely/migrations/2023-08-01.ts b/test/kysely/migrations/2023-08-01.ts
@@ -1,4 +1,5 @@
-import { Kysely, Migration } from 'kysely';
+import { Kysely } from 'kysely';
+import type { Migration } from 'kysely';
 
 export const Migration20230801: Migration = {
 	async up(db: Kysely<any>) {

diff --git a/test/kysely/migrations/2023-08-02.ts b/test/kysely/migrations/2023-08-02.ts
@@ -1,4 +1,5 @@
-import { Kysely, Migration } from 'kysely';
+import { Kysely } from 'kysely';
+import type { Migration } from 'kysely';
 
 export const Migration20230802: Migration = {
 	async up(db: Kysely<any>) {

diff --git a/test/kysely/migrations/index.ts b/test/kysely/migrations/index.ts
@@ -1,6 +1,6 @@
-import { Migration } from 'kysely';
-import { Migration20230801 } from './2023-08-01';
-import { Migration20230802 } from './2023-08-02';
+import type { Migration } from 'kysely';
+import { Migration20230801 } from './2023-08-01.js';
+import { Migration20230802 } from './2023-08-02.js';
 
 export const migrations: Record<string, Migration> = {
 	'2023-08-02': Migration20230802,

diff --git a/test/overwrite-database-file.test.ts b/test/overwrite-database-file.test.ts
@@ -1,5 +1,5 @@
 import { describe, it, expect, afterAll } from 'vitest';
-import { SQLocal } from '../src/index';
+import { SQLocal } from '../src/index.js';
 
 describe('overwriteDatabaseFile', async () => {
 	const db1 = new SQLocal('overwrite-test-db1.sqlite3');

diff --git a/test/sql.test.ts b/test/sql.test.ts
@@ -1,5 +1,5 @@
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { SQLocal } from '../src/index';
+import { SQLocal } from '../src/index.js';
 
 describe('sql', () => {
 	const { sql } = new SQLocal('sql-test.sqlite3');

diff --git a/test/transaction.test.ts b/test/transaction.test.ts
@@ -1,6 +1,6 @@
 import { afterEach, beforeEach, describe, expect, it } from 'vitest';
-import { SQLocal } from '../src/index';
-import { sleep } from './test-utils/sleep';
+import { SQLocal } from '../src/index.js';
+import { sleep } from './test-utils/sleep.js';
 
 describe('transaction', () => {
 	const { sql, transaction } = new SQLocal('transaction-test.sqlite3');

diff --git a/tsconfig.build.json b/tsconfig.build.json
@@ -0,0 +1,4 @@
+{
+	"extends": "./tsconfig.json",
+	"exclude": ["test"]
+}
diff --git a/tsconfig.json b/tsconfig.json
@@ -6,6 +6,7 @@
 
 		/* Building */
 		"moduleResolution": "NodeNext",
+		"moduleDetection": "force",
 		"esModuleInterop": true,
 		"useDefineForClassFields": true,
 		"allowSyntheticDefaultImports": true,
@@ -21,8 +22,9 @@
 		"noUnusedLocals": true,
 		"noUnusedParameters": true,
 		"noFallthroughCasesInSwitch": true,
+		"noImplicitOverride": true,
 		"verbatimModuleSyntax": true
 	},
-	"include": ["src"],
+	"include": ["src", "test"],
 	"exclude": ["**/node_modules/**", "dist"]
 }