feat: Chat Web API (now with no threading) #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add all previous POC api endpoints
Closed
aronwk-aaron
requested review from
EmosewaMC,
jadebenn,
Jettford,
Xiphoseer and
Wincent01
and removed request for
EmosewaMC and
jadebenn
Xiphoseer
previously approved these changes
Jan 2, 2025
EmosewaMC
reviewed
Jan 3, 2025
EmosewaMC
requested changes
Jan 3, 2025
There was a problem hiding this comment.
questions and some ways to consider designing where the logic is handled
we should chat about what I think would be an easier to read message handler for the webapi server (moving the actual logic to the places that own it, and only using the handler to receive, figure out where it goes, and return a result
Co-authored-by: David Markowitz <[email protected]>
Co-authored-by: David Markowitz <[email protected]>
Co-authored-by: David Markowitz <[email protected]>
Wincent01
reviewed
Jan 3, 2025
Xiphoseer
reviewed
Jan 6, 2025
Co-authored-by: Daniel Seiler <[email protected]>
|
my commit isnt a merge commit, forgot to rename it |
jadebenn
reviewed
Jan 7, 2025
|
re-working some stuff |
jadebenn
reviewed
Jan 10, 2025
Jettford
approved these changes
Jan 16, 2025
EmosewaMC
reviewed
Jan 17, 2025
EmosewaMC
approved these changes
Jan 17, 2025
|
I worked on this so I cannot approve this technically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using mongoose for the http lib
Web API for Chat server Minimum Viable Product
Features:
resolves #450