Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-8744] CLS tracking: provide cls devicePixelRatio #3389

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anediaz
Copy link

@anediaz anediaz commented Mar 3, 2025

Motivation

https://datadoghq.atlassian.net/browse/RUM-8744

Implementation of small adjustments in Browser SDK for CLS attribution:

  • Include devicePixelRatio attribute:
    • Recent discoveries showed that Layout Instability API does not report viewPort coordinates for prevRect and currentRect.
    • We'd need to include this data in _dd.cls.device_pixel_ratio. See this document for more context
image

Changes

  • Include new attribute devicePixelRatio in the CLS attribution

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bits-bot
Copy link

bits-bot commented Mar 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants