Support node 23 (#111)

DataDog · Oct 22, 2024 · 76f9c2a · 76f9c2a
1 parent fbd5646
commit 76f9c2a
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 9 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -11,7 +11,7 @@ jobs:
     needs: ['cpp-lint', 'js-lint']
     strategy:
       matrix:
-        version: [16, 17, 18, 19, 20, 21, 22]
+        version: [16, 17, 18, 19, 20, 21, 22, 23]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -28,7 +28,7 @@ jobs:
     needs: ['cpp-lint', 'js-lint']
     strategy:
       matrix:
-        version: [16, 17, 18, 19, 20, 21, 22]
+        version: [16, 17, 18, 19, 20, 21, 22, 23]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -7,7 +7,7 @@ jobs:
     needs: ['cpp-lint', 'js-lint']
     strategy:
       matrix:
-        version: [16, 18, 19, 20, 21, 22]
+        version: [16, 18, 19, 20, 21, 22, 23]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -24,7 +24,7 @@ jobs:
     needs: ['cpp-lint', 'js-lint']
     strategy:
       matrix:
-        version: [16, 18, 19, 20, 21, 22]
+        version: [16, 18, 19, 20, 21, 22, 23]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,6 +1,6 @@
 cmake_minimum_required(VERSION 3.9)
 cmake_policy(SET CMP0042 NEW)
-set (CMAKE_CXX_STANDARD 17)
+set (CMAKE_CXX_STANDARD 20)
 set (CMAKE_CXX_COMPILER clang++)
 
 project(dd-native-iast-taint-tracking-js)

diff --git a/binding.gyp b/binding.gyp
@@ -26,15 +26,20 @@
                 "<!(node -e \"require('nan')\")"
             ],
             "cflags!": [ "-fno-exceptions", "-fno-rtti" ],
-            "cflags_cc!": [ "-fno-exceptions", "-fno-rtti"  ],
-            "cflags_cc": [ "-std=c++17" ],
+            "cflags_cc!": [ "-fno-exceptions", "-fno-rtti", "-std=gnu++20"  ],
+            "cflags_cc": [ "-std=gnu++2a" ],
             "conditions": [
                 ['OS=="mac"', {
                     "xcode_settings": {
-                        "MACOSX_DEPLOYMENT_TARGET": "10.7",
+                        "MACOSX_DEPLOYMENT_TARGET": "10.10",
                         "CLANG_CXX_LIBRARY": "libc++",
                         "GCC_ENABLE_CPP_EXCEPTIONS": "YES",
-                        "GCC_ENABLE_CPP_RTTI": "YES"
+                        "GCC_ENABLE_CPP_RTTI": "YES",
+                        "OTHER_CFLAGS": [
+                            "-std=c++20",
+                            "-stdlib=libc++",
+                            "-Wall"
+                        ]
                     }
                 }],
                 ['OS=="win"', {