createNewTainted flag for the AddSecureMarksToTaintedString method #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| let referenceEqual | ||
| function makeReferenceEqual () { | ||
| // eslint-disable-next-line no-new-func | ||
| referenceEqual = new Function('value1', 'value2', 'return %ReferenceEqual(value1, value2)') |
There was a problem hiding this comment.
🟠 Code Quality Violation
The Function constructor is eval. (...read more)
The Function constructor can lead to code similar to eval executions. Use function declarations instead of the Function constructor.
Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>
IlyasShabi
approved these changes
Jan 16, 2025
uurien
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
createNewTaintedargument toAddSecureMarksToTaintedStringmethod:undefinedortrueAddSecureMarksToTaintedStringwill continue creating a new tainted with the secure marks.falsethe method will update the tainted with the new markssecure_marks_tasuint32_tto allow more secure marks as we need one for each vulnerability type and some more.Motivation
Additional Notes
Checklist