-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename exceptionId to exceptionCaptureId #8637
base: master
Are you sure you want to change the base?
Conversation
add exceptionHash and frame index in snapshot attributes
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (315.064 µs) : 280, 350
. : milestone, 315,
basic (313.562 µs) : 304, 323
. : milestone, 314,
loop (10.813 ms) : 10787, 10840
. : milestone, 10813,
section candidate
noprobe (326.822 µs) : 277, 376
. : milestone, 327,
basic (314.935 µs) : 302, 328
. : milestone, 315,
loop (10.463 ms) : 10354, 10571
. : milestone, 10463,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~b22e72369a, baseline=1.48.0-SNAPSHOT~4f278de73a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046694
Total [baseline] (10.399 s) : 0, 10399484
Agent [candidate] (1.047 s) : 0, 1047277
Total [candidate] (10.412 s) : 0, 10411881
section appsec
Agent [baseline] (1.193 s) : 0, 1192853
Total [baseline] (10.732 s) : 0, 10732275
Agent [candidate] (1.19 s) : 0, 1190331
Total [candidate] (10.764 s) : 0, 10763877
section iast
Agent [baseline] (1.189 s) : 0, 1188551
Total [baseline] (11.078 s) : 0, 11077836
Agent [candidate] (1.173 s) : 0, 1173085
Total [candidate] (10.965 s) : 0, 10965098
section profiling
Agent [baseline] (1.28 s) : 0, 1280392
Total [baseline] (10.836 s) : 0, 10835904
Agent [candidate] (1.277 s) : 0, 1277056
Total [candidate] (10.841 s) : 0, 10840937
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~b22e72369a, baseline=1.48.0-SNAPSHOT~4f278de73a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.094 ms) : 0, 717094
BytebuddyAgent [candidate] (722.675 ms) : 0, 722675
GlobalTracer [baseline] (238.456 ms) : 0, 238456
GlobalTracer [candidate] (241.016 ms) : 0, 241016
AppSec [baseline] (54.249 ms) : 0, 54249
AppSec [candidate] (54.672 ms) : 0, 54672
Remote Config [baseline] (692.845 µs) : 0, 693
Remote Config [candidate] (685.942 µs) : 0, 686
Telemetry [baseline] (12.068 ms) : 0, 12068
Telemetry [candidate] (12.137 ms) : 0, 12137
Debugger [baseline] (4.434 ms) : 0, 4434
section appsec
BytebuddyAgent [baseline] (737.697 ms) : 0, 737697
BytebuddyAgent [candidate] (740.481 ms) : 0, 740481
GlobalTracer [baseline] (235.31 ms) : 0, 235310
GlobalTracer [candidate] (237.545 ms) : 0, 237545
AppSec [baseline] (176.242 ms) : 0, 176242
AppSec [candidate] (176.005 ms) : 0, 176005
Remote Config [baseline] (638.96 µs) : 0, 639
Remote Config [candidate] (656.677 µs) : 0, 657
Telemetry [baseline] (8.156 ms) : 0, 8156
Telemetry [candidate] (8.607 ms) : 0, 8607
Debugger [baseline] (4.295 ms) : 0, 4295
IAST [baseline] (21.553 ms) : 0, 21553
IAST [candidate] (21.94 ms) : 0, 21940
section iast
BytebuddyAgent [baseline] (844.776 ms) : 0, 844776
BytebuddyAgent [candidate] (838.692 ms) : 0, 838692
GlobalTracer [baseline] (230.968 ms) : 0, 230968
GlobalTracer [candidate] (230.38 ms) : 0, 230380
AppSec [baseline] (56.199 ms) : 0, 56199
AppSec [candidate] (55.964 ms) : 0, 55964
Remote Config [baseline] (612.429 µs) : 0, 612
Remote Config [candidate] (602.912 µs) : 0, 603
Telemetry [baseline] (8.823 ms) : 0, 8823
Telemetry [candidate] (8.632 ms) : 0, 8632
Debugger [baseline] (4.226 ms) : 0, 4226
IAST [baseline] (23.104 ms) : 0, 23104
IAST [candidate] (22.885 ms) : 0, 22885
section profiling
BytebuddyAgent [baseline] (714.948 ms) : 0, 714948
BytebuddyAgent [candidate] (718.698 ms) : 0, 718698
GlobalTracer [baseline] (349.913 ms) : 0, 349913
GlobalTracer [candidate] (353.065 ms) : 0, 353065
AppSec [baseline] (54.317 ms) : 0, 54317
AppSec [candidate] (55.274 ms) : 0, 55274
Remote Config [baseline] (678.124 µs) : 0, 678
Remote Config [candidate] (716.559 µs) : 0, 717
Telemetry [baseline] (8.859 ms) : 0, 8859
Telemetry [candidate] (9.127 ms) : 0, 9127
Debugger [baseline] (4.275 ms) : 0, 4275
ProfilingAgent [baseline] (102.007 ms) : 0, 102007
ProfilingAgent [candidate] (98.104 ms) : 0, 98104
Profiling [baseline] (102.169 ms) : 0, 102169
Profiling [candidate] (98.128 ms) : 0, 98128
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~b22e72369a, baseline=1.48.0-SNAPSHOT~4f278de73a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069003
Total [baseline] (8.686 s) : 0, 8685932
Agent [candidate] (1.054 s) : 0, 1053636
Total [candidate] (8.718 s) : 0, 8717558
section iast
Agent [baseline] (1.175 s) : 0, 1174967
Total [baseline] (9.254 s) : 0, 9254306
Agent [candidate] (1.171 s) : 0, 1171034
Total [candidate] (9.249 s) : 0, 9249003
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175992
Total [baseline] (9.206 s) : 0, 9206372
Agent [candidate] (1.18 s) : 0, 1179738
Total [candidate] (9.182 s) : 0, 9182463
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173182
Total [baseline] (9.244 s) : 0, 9244173
Agent [candidate] (1.174 s) : 0, 1174095
Total [candidate] (9.289 s) : 0, 9288624
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~b22e72369a, baseline=1.48.0-SNAPSHOT~4f278de73a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (733.791 ms) : 0, 733791
BytebuddyAgent [candidate] (728.223 ms) : 0, 728223
GlobalTracer [baseline] (241.089 ms) : 0, 241089
GlobalTracer [candidate] (242.562 ms) : 0, 242562
AppSec [baseline] (55.014 ms) : 0, 55014
AppSec [candidate] (55.478 ms) : 0, 55478
Remote Config [baseline] (709.086 µs) : 0, 709
Remote Config [candidate] (698.134 µs) : 0, 698
Telemetry [baseline] (13.761 ms) : 0, 13761
Telemetry [candidate] (10.339 ms) : 0, 10339
Debugger [baseline] (4.476 ms) : 0, 4476
section iast
BytebuddyAgent [baseline] (834.71 ms) : 0, 834710
BytebuddyAgent [candidate] (837.423 ms) : 0, 837423
GlobalTracer [baseline] (228.591 ms) : 0, 228591
GlobalTracer [candidate] (229.933 ms) : 0, 229933
IAST [baseline] (22.86 ms) : 0, 22860
IAST [candidate] (23.392 ms) : 0, 23392
AppSec [baseline] (55.565 ms) : 0, 55565
AppSec [candidate] (55.057 ms) : 0, 55057
Remote Config [baseline] (627.532 µs) : 0, 628
Remote Config [candidate] (598.693 µs) : 0, 599
Telemetry [baseline] (8.775 ms) : 0, 8775
Telemetry [candidate] (8.68 ms) : 0, 8680
Debugger [baseline] (4.202 ms) : 0, 4202
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.628 ms) : 0, 835628
BytebuddyAgent [candidate] (842.893 ms) : 0, 842893
GlobalTracer [baseline] (228.492 ms) : 0, 228492
GlobalTracer [candidate] (231.452 ms) : 0, 231452
IAST [baseline] (22.849 ms) : 0, 22849
IAST [candidate] (23.329 ms) : 0, 23329
AppSec [baseline] (55.738 ms) : 0, 55738
AppSec [candidate] (56.499 ms) : 0, 56499
Remote Config [baseline] (612.019 µs) : 0, 612
Remote Config [candidate] (631.562 µs) : 0, 632
Telemetry [baseline] (8.797 ms) : 0, 8797
Telemetry [candidate] (8.823 ms) : 0, 8823
Debugger [baseline] (4.224 ms) : 0, 4224
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.965 ms) : 0, 833965
BytebuddyAgent [candidate] (839.22 ms) : 0, 839220
GlobalTracer [baseline] (228.085 ms) : 0, 228085
GlobalTracer [candidate] (230.966 ms) : 0, 230966
IAST [baseline] (22.326 ms) : 0, 22326
IAST [candidate] (23.222 ms) : 0, 23222
AppSec [baseline] (55.807 ms) : 0, 55807
AppSec [candidate] (55.371 ms) : 0, 55371
Remote Config [baseline] (587.909 µs) : 0, 588
Remote Config [candidate] (600.234 µs) : 0, 600
Telemetry [baseline] (8.675 ms) : 0, 8675
Telemetry [candidate] (8.571 ms) : 0, 8571
Debugger [baseline] (4.137 ms) : 0, 4137
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~b22e72369a, baseline=1.48.0-SNAPSHOT~4f278de73a
dateFormat X
axisFormat %s
section baseline
no_agent (1.369 ms) : 1350, 1389
. : milestone, 1369,
appsec (1.746 ms) : 1722, 1769
. : milestone, 1746,
appsec_no_iast (1.745 ms) : 1722, 1767
. : milestone, 1745,
code_origins (1.687 ms) : 1660, 1715
. : milestone, 1687,
iast (1.538 ms) : 1514, 1562
. : milestone, 1538,
profiling (1.511 ms) : 1487, 1536
. : milestone, 1511,
tracing (1.473 ms) : 1447, 1498
. : milestone, 1473,
section candidate
no_agent (1.357 ms) : 1337, 1376
. : milestone, 1357,
appsec (1.72 ms) : 1697, 1744
. : milestone, 1720,
appsec_no_iast (1.727 ms) : 1703, 1752
. : milestone, 1727,
code_origins (1.671 ms) : 1643, 1699
. : milestone, 1671,
iast (1.512 ms) : 1488, 1537
. : milestone, 1512,
profiling (1.494 ms) : 1470, 1517
. : milestone, 1494,
tracing (1.49 ms) : 1465, 1514
. : milestone, 1490,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~b22e72369a, baseline=1.48.0-SNAPSHOT~4f278de73a
dateFormat X
axisFormat %s
section baseline
no_agent (383.201 µs) : 363, 403
. : milestone, 383,
iast (523.716 µs) : 501, 547
. : milestone, 524,
iast_FULL (730.889 µs) : 709, 753
. : milestone, 731,
iast_GLOBAL (564.148 µs) : 542, 587
. : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (519.886 µs) : 498, 542
. : milestone, 520,
iast_INACTIVE (460.299 µs) : 439, 482
. : milestone, 460,
iast_TELEMETRY_OFF (498.582 µs) : 477, 520
. : milestone, 499,
tracing (456.723 µs) : 436, 477
. : milestone, 457,
section candidate
no_agent (379.066 µs) : 359, 399
. : milestone, 379,
iast (509.341 µs) : 488, 531
. : milestone, 509,
iast_FULL (728.979 µs) : 707, 751
. : milestone, 729,
iast_GLOBAL (554.765 µs) : 533, 576
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (512.01 µs) : 490, 534
. : milestone, 512,
iast_INACTIVE (459.726 µs) : 437, 482
. : milestone, 460,
iast_TELEMETRY_OFF (498.365 µs) : 477, 520
. : milestone, 498,
tracing (464.044 µs) : 442, 486
. : milestone, 464,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~b22e72369a, baseline=1.48.0-SNAPSHOT~4f278de73a
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (2.356 ms) : 2312, 2400
. : milestone, 2356,
iast (2.133 ms) : 2077, 2189
. : milestone, 2133,
iast_GLOBAL (2.165 ms) : 2110, 2221
. : milestone, 2165,
profiling (1.986 ms) : 1941, 2030
. : milestone, 1986,
tracing (1.959 ms) : 1916, 2002
. : milestone, 1959,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.361 ms) : 2316, 2405
. : milestone, 2361,
iast (2.124 ms) : 2068, 2180
. : milestone, 2124,
iast_GLOBAL (2.179 ms) : 2123, 2236
. : milestone, 2179,
profiling (1.98 ms) : 1935, 2025
. : milestone, 1980,
tracing (1.962 ms) : 1919, 2005
. : milestone, 1962,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~b22e72369a, baseline=1.48.0-SNAPSHOT~4f278de73a
dateFormat X
axisFormat %s
section baseline
no_agent (14.777 s) : 14777000, 14777000
. : milestone, 14777000,
appsec (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
iast (18.629 s) : 18629000, 18629000
. : milestone, 18629000,
iast_GLOBAL (17.64 s) : 17640000, 17640000
. : milestone, 17640000,
profiling (15.162 s) : 15162000, 15162000
. : milestone, 15162000,
tracing (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
section candidate
no_agent (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
appsec (15.1 s) : 15100000, 15100000
. : milestone, 15100000,
iast (18.781 s) : 18781000, 18781000
. : milestone, 18781000,
iast_GLOBAL (18.19 s) : 18190000, 18190000
. : milestone, 18190000,
profiling (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
tracing (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
|
What Does This Do
add exceptionHash and frame index in snapshot attributes
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-3643