ESLint: Require 'use strict' header

[watson]

What does this PR do?

Require strict mode on all CommonJS modules.

[watson]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• ESLint: Require 'use strict' header #5334 👈 (View in Graphite)
• Enable recommended rules for eslint-plugin-n #5216 : 3 other dependent PRs (#5218 , #5274 , #5320 )
• Upgrade ESLint from v8 to v9 #5215
• Clean up ESLint config #5214
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Overall package size

Self size: 8.82 MB
Deduped: 95.02 MB
No deduping: 95.54 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.72%. Comparing base (cc489e5) to head (b0bec89).

Additional details and impacted files

@@                        Coverage Diff                        @@
##           watson/enable-eslint-plugin-n    #5334      +/-   ##
=================================================================
- Coverage                          80.56%   76.72%   -3.84%     
=================================================================
  Files                                480      476       -4     
  Lines                              21607    21656      +49     
=================================================================
- Hits                               17408    16616     -792     
- Misses                              4199     5040     +841     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[datadog-datadog-prod-us1]

Datadog Report

Branch report: watson/strict2
Commit report: 9139011
Test service: dd-trace-js-integration-tests

❌ 15 Failed (0 Known Flaky), 622 Passed, 0 Skipped, 11m 49.06s Total Time
❄️ 1 New Flaky

❌ Failed Tests (15)

This report shows up to 5 failed tests.

• cucumber@latest commonJS reporting via agentless dynamic instrumentation runs retries with dynamic instrumentation - integration-tests/cucumber/cucumber.spec.js - Details

  Expand for error

   expected 6 to equal 4
  

• cucumber@latest commonJS reporting via agentless dynamic instrumentation runs retries with dynamic instrumentation - integration-tests/cucumber/cucumber.spec.js - Details

  Expand for error

   expected 6 to equal 4
  

• cucumber@latest commonJS reporting via evp proxy dynamic instrumentation runs retries with dynamic instrumentation - integration-tests/cucumber/cucumber.spec.js - Details

  Expand for error

   expected 6 to equal 4
  

• jest CommonJS intelligent test runner does not skip suites if suite is marked as unskippable - integration-tests/jest/jest.spec.js - Details

  Expand for error

   expected { '_dd.p.dm': '-0', …(45) } to have property 'test.itr.forced_run'
  

• jest CommonJS intelligent test runner does not skip suites if suite is marked as unskippable - integration-tests/jest/jest.spec.js - Details

  Expand for error

   expected { '_dd.p.dm': '-0', …(45) } to have property 'test.itr.forced_run'
  

New Flaky Tests (1)

• [email protected] works when tests are compiled to a different location - integration-tests/playwright/playwright.spec.js - Last Failure

  Expand for error

   expected [] to be a superset of [ …(2) ]
  

[pr-commenter]

Benchmarks

Benchmark execution time: 2025-02-27 08:45:33

Comparing candidate commit b0bec89 in PR branch watson/strict2 with baseline commit cc489e5 in branch watson/enable-eslint-plugin-n.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 918 metrics, 15 unstable metrics.

[simon-id]

I've reviewed all 344 files in the previous PR, I don't think i have the strength to do it again :/