Skip to content

chore(iast): fix for dict add inplace #13372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

smola
Copy link
Member

@smola smola commented May 9, 2025

APPSEC-57605

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented May 9, 2025

CODEOWNERS have been resolved as:

benchmarks/bm/iast_fixtures/str_methods.py                              @DataDog/asm-python
ddtrace/appsec/_iast/_ast/visitor.py                                    @DataDog/asm-python
tests/appsec/iast/aspects/test_add_inplace_aspect_fixtures.py           @DataDog/asm-python

Copy link
Contributor

github-actions bot commented May 9, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 234 ± 3 ms.

The average import time from base is: 238 ± 4 ms.

The import time difference between this PR and base is: -3.2 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.125 ms (0.91%)
ddtrace.bootstrap.sitecustomize 1.445 ms (0.62%)
ddtrace.bootstrap.preload 1.445 ms (0.62%)
ddtrace.internal.remoteconfig.client 0.693 ms (0.30%)
ddtrace 0.680 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented May 9, 2025

Benchmarks

Benchmark execution time: 2025-05-14 14:40:57

Comparing candidate commit b01c087 in PR branch smola/test-dict-add-inplace with baseline commit 01bb3a5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 523 metrics, 5 unstable metrics.

@avara1986 avara1986 added ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR. labels May 13, 2025
@avara1986 avara1986 changed the title iast: test for dict add inplace chore(iast): fix for dict add inplace May 13, 2025
@avara1986 avara1986 marked this pull request as ready for review May 13, 2025 14:53
@avara1986 avara1986 requested a review from a team as a code owner May 13, 2025 14:53
@smola smola changed the title chore(iast): fix for dict add inplace fix(iast): fix for dict add inplace May 14, 2025
@avara1986 avara1986 changed the title fix(iast): fix for dict add inplace chore(iast): fix for dict add inplace May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants