Create a prefix in each instrumented file #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uurien
commented
Dec 9, 2024
uurien
commented
Dec 9, 2024
scripts/crawler.js
Outdated
There was a problem hiding this comment.
As we are adding the prefix by default in each file, the code for add no ops in v8 tests are not necessary anymore.
iunanua
reviewed
Dec 10, 2024
* Keep lib_wasm swc agnostic * Use swc Stmt::is_use_strict
uurien
force-pushed
the
ugaitz/protect-if-no-_ddiast-exist
branch
from
e57699d to
a8d3be7
Compare
iunanua
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a prefix in each instrumented file to prevent crashes when the
global._ddiastobject is not initialized.Motivation
When instrumentation is done with ESM, we can not be sure that the rewrite is coming from a thread where tracer and iast are initialized.
Additional Notes
Describe how to test your changes
Checklist