Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update swc to v15.0.0 #115

Merged
merged 3 commits into from
Mar 5, 2025
Merged

update swc to v15.0.0 #115

merged 3 commits into from
Mar 5, 2025

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented Feb 26, 2025

What does this PR do?

See title

Motivation

I'm trying to pull in a library that depends on a much newer version of SWC.

Additional Notes

Describe how to test your changes

Checklist

  • The CHANGELOG.md has been updated
  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected

@bengl bengl requested a review from a team as a code owner February 26, 2025 13:48
@bengl bengl force-pushed the bengl/update-swc-to-15 branch from fcfea01 to b289336 Compare February 26, 2025 14:02
@bengl bengl force-pushed the bengl/update-swc-to-15 branch from 0ba49ea to c1bcc47 Compare February 26, 2025 14:23
Cargo.toml Outdated
Comment on lines 37 to 38
[net]
git-fetch-with-cli = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not. I'll remove it.

Copy link
Collaborator

@uurien uurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment added

uurien
uurien previously approved these changes Mar 5, 2025
@bengl
Copy link
Collaborator Author

bengl commented Mar 5, 2025

@uurien I removed the unnecessary toml entry

@bengl bengl merged commit b9dfa05 into main Mar 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants