Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rewrite on methods without callee #84

Merged
merged 11 commits into from
Jul 18, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Jul 11, 2024

What does this PR do?

Support rewriting methods without callee, like method(param) instead of obj.method(param).

Motivation

Are methods that we want to instrument with rewriter that can be used without callee, like eval

Checklist

  • Unit tests have been updated and pass

@uurien uurien marked this pull request as ready for review July 17, 2024 10:53
@uurien uurien requested a review from a team as a code owner July 17, 2024 10:53
@iunanua
Copy link
Collaborator

iunanua commented Jul 17, 2024

ah, you could try to rewrite the real eval (or evil) of the v8 tests including { src: 'eval', allowedWithoutCallee: true } csi method here

@uurien uurien merged commit 68b0e57 into main Jul 18, 2024
20 checks passed
@uurien uurien deleted the ugaitz/support-rewrite-method-without-callee branch July 18, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants