Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use an ident for literals #95

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Do not use an ident for literals #95

merged 1 commit into from
Sep 5, 2024

Conversation

iunanua
Copy link
Collaborator

@iunanua iunanua commented Sep 3, 2024

What does this PR do?

Do not use an ident for literals

Motivation

Additional Notes

Describe how to test your changes

Checklist

  • The CHANGELOG.md has been updated
  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected

@iunanua iunanua changed the base branch from main to igor/rewrite-more-call-apply-expr September 3, 2024 12:37
@iunanua iunanua force-pushed the igor/use-less-idents-for-literals branch from 6401764 to 286517b Compare September 3, 2024 13:27
@iunanua iunanua marked this pull request as ready for review September 3, 2024 15:30
@iunanua iunanua requested a review from a team as a code owner September 3, 2024 15:30
@iunanua iunanua merged commit 6274fd0 into igor/rewrite-more-call-apply-expr Sep 5, 2024
15 checks passed
iunanua added a commit that referenced this pull request Sep 5, 2024
@iunanua
Rewrite some expressions like String.prototype[concat|replace].[call|…
4e7b346 
…apply]("literal", ...args) (#93)

* Rewrite some String.prototype[concat|replace|].call expressions

* Add a some more v8 tests

* Clean up

* suggested test case

* Use Expr provided method

* Do not use a generated ident for literals (#95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uurien uurien uurien approved these changes

@CarlesDD CarlesDD CarlesDD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iunanua @uurien @CarlesDD