Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin libfaketime #17229

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Pin libfaketime #17229

merged 1 commit into from
Mar 20, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Mar 20, 2024

What does this PR do?

Pin libfaketime in our docker images

Motivation

wolfcw/libfaketime#467 broke us https://github.com/DataDog/integrations-core/actions/runs/8355648482/job/22871222835

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (db499c4) to head (d057eb3).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
http_check 95.32% <ø> (+2.02%) ⬆️
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tls 92.93% <ø> (+0.87%) ⬆️
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret marked this pull request as ready for review March 20, 2024 09:42
@FlorentClarret FlorentClarret requested a review from a team as a code owner March 20, 2024 09:42
Copy link

Test Results

  8 files    8 suites   2m 1s ⏱️
110 tests 109 ✅ 1 💤 0 ❌
224 runs  215 ✅ 9 💤 0 ❌

Results for commit d057eb3.

@FlorentClarret FlorentClarret merged commit ba8461e into master Mar 20, 2024
46 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/fix_tests branch March 20, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants