Fix slurm partition metrics with proper name #20169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert this change. Should be handled in another PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
steveny91
changed the title
Kyle-Neale
reviewed
Apr 29, 2025
Kyle-Neale
previously approved these changes
Apr 29, 2025
Co-authored-by: Kyle Neale <[email protected]>
temporal-github-worker-1
bot
dismissed
Kyle-Neale’s stale review
Review from Kyle-Neale is dismissed. Related teams and files:
- agent-integrations
- slurm/changelog.d/20169.fixed
Kyle-Neale
previously approved these changes
Apr 30, 2025
temporal-github-worker-1
bot
dismissed
Kyle-Neale’s stale review
Review from Kyle-Neale is dismissed. Related teams and files:
- agent-integrations
- slurm/datadog_checks/slurm/check.py
- slurm/datadog_checks/slurm/constants.py
- slurm/metadata.csv
- slurm/tests/common.py
Kyle-Neale
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small fix to a tag that was named incorrectly. Also changes the name of a set of metrics. These metrics don't represent the cpu allocated etc, but more so the state of the node. Renamed the function since the purpose of it has now changed.