Skip to content

Update permissions needed for github actions that run tests #20239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2025

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented May 7, 2025

What does this PR do?

Github actions that run tests need to be able to read contents of branches that run tests. Additing the id-token: write permission stopped allowing any read permisisons

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (9a7dc8d) to head (705bb1a).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
arangodb 98.23% <ø> (ø)
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarah-witt sarah-witt changed the title test Update permissions needed for github actions that run tests May 7, 2025
@sarah-witt sarah-witt marked this pull request as ready for review May 7, 2025 19:11
@sarah-witt sarah-witt requested a review from a team as a code owner May 7, 2025 19:11
Kyle-Neale
Kyle-Neale previously approved these changes May 7, 2025
@sarah-witt sarah-witt enabled auto-merge May 8, 2025 20:29
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed Kyle-Neale’s stale review May 8, 2025 20:29

Review from Kyle-Neale is dismissed. Related teams and files:

  • agent-integrations
    • .github/workflows/test-fips-e2e.yml
    • .github/workflows/test-target.yml
@sarah-witt sarah-witt added this pull request to the merge queue May 8, 2025
Merged via the queue into master with commit 5657f0e May 8, 2025
18 checks passed
@sarah-witt sarah-witt deleted the sarah/test-permissions-workflow branch May 8, 2025 20:38
@datadog-agent-integrations-bot
Copy link
Contributor

The backport to 7.66.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.66.x 7.66.x
# Navigate to the new working tree
cd .worktrees/backport-7.66.x
# Create a new branch
git switch --create backport-20239-to-7.66.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5657f0e31f408090072456264444e087b58d1ed3
# Push it to GitHub
git push --set-upstream origin backport-20239-to-7.66.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.66.x

Then, create a pull request where the base branch is 7.66.x and the compare/head branch is backport-20239-to-7.66.x.

@sarah-witt sarah-witt mentioned this pull request May 15, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants