Skip to content

Fixed bug with no parameter prepared statements #20243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aldrickdev
Copy link
Contributor

@aldrickdev aldrickdev commented May 8, 2025

What does this PR do?

Fixed bug where we fail to explain parameterized queries if the query has no parameters.

Motivation

SDBM-1718

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (717d94d) to head (5fad59d).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
postgres 93.34% <100.00%> (+3.65%) ⬆️
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nenadnoveljic nenadnoveljic enabled auto-merge May 9, 2025 13:33
@nenadnoveljic nenadnoveljic added this pull request to the merge queue May 12, 2025
Merged via the queue into master with commit 874e582 May 12, 2025
18 checks passed
@nenadnoveljic nenadnoveljic deleted the aldrick.castro/SDBM-1718-Agent-Error-when-Explaining-Prepared-Statments branch May 12, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants