feat: add process discovery tests #3981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
force-pushed
the
dmehala/process-discovery-feature
branch
3 times, most recently
from
d8295c0 to
4789a86
Compare
cbeauchesne
requested changes
Feb 11, 2025
dmehala
force-pushed
the
dmehala/process-discovery-feature
branch
from
bed98ec to
aa2146e
Compare
dmehala
force-pushed
the
dmehala/process-discovery-feature
branch
from
bb23500 to
76ade03
Compare
dmehala
requested review from
zacharycmontoya and
cbeauchesne
and removed request for
a team
cbeauchesne
reviewed
Feb 20, 2025
manifests/cpp.yml
Outdated
| @@ -211,6 +211,7 @@ tests/: | |||
| Test_Parametric_Otel_Baggage: missing_feature (otel api is not supported) | |||
| Test_Parametric_Otel_Current_Span: missing_feature (otel api is not supported) | |||
| Test_Parametric_Otel_Trace_Flush: missing_feature (otel api is not supported) | |||
| test_process_discovery.py: v1.0.1.dev | |||
There was a problem hiding this comment.
The error in the CI is not very clear 😭
- versions can only be set at class level (I'm not sure if it's a good limitation ... )
- and keys must be sorted
I'll fix both issues
cbeauchesne
approved these changes
Feb 20, 2025
cbeauchesne
approved these changes
Feb 26, 2025
Genuine question, should they block the PR then? |
7 tasks
|
They are now blocking the PR, see https://dd.slack.com/archives/C025TJ4RZ8X/p1740584874789959 😅 Those failure are caused by a test using data coming from staging backend which is not stable enough for our purpose. Though, the situation was not that bad for the past 5 months, it has been a while I didn't see them failing. No luck 😭 I'll handle your PR and ping you once it's merged. |
|
ping @dmehala |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test process discovery feature. RFC
Changes
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present