Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental runs-on input #4167

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Add experimental runs-on input #4167

merged 2 commits into from
Feb 26, 2025

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Feb 21, 2025

Motivation

The workflow is reusable and allows parallel batching via tuning job count and matrix.

It does not allow selection of which kind of runner to run these on though.

Changes

  • Add experimental runs-on input
  • Default runs-on to the previous value

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@lloeki lloeki requested a review from a team as a code owner February 21, 2025 12:08
@lloeki lloeki force-pushed the lloeki/add-runs-on-parameter branch from d26145e to 5ee474e Compare February 21, 2025 12:10
@lloeki
Copy link
Member Author

lloeki commented Feb 21, 2025

Screenshot 2025-02-21 at 13 13 30 Screenshot 2025-02-21 at 13 16 25

Looks like the APM Larger Runners is properly picked up as a default

Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures are not related

@lloeki lloeki merged commit 30f4878 into main Feb 26, 2025
272 of 275 checks passed
@lloeki lloeki deleted the lloeki/add-runs-on-parameter branch February 26, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants