Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloading for yamlfmt #4172

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fix downloading for yamlfmt #4172

merged 2 commits into from
Feb 26, 2025

Conversation

bm1549
Copy link
Contributor

@bm1549 bm1549 commented Feb 23, 2025

Motivation

Fixes the downloading for yamlfmt after reading through the docs a bit more thoroughly

Changes

Updates the download script to find the correct downloadable by OS + arch

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@bm1549 bm1549 mentioned this pull request Feb 23, 2025
7 tasks
@bm1549 bm1549 force-pushed the brian.marks/long-live-yamlfmt branch from 8a71a60 to b1c185d Compare February 23, 2025 20:21
@bm1549 bm1549 marked this pull request as ready for review February 24, 2025 14:37
@bm1549 bm1549 requested review from a team as code owners February 24, 2025 14:37
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on mac/intel, works fine. lets go for another try !

@bm1549 bm1549 merged commit ac41859 into main Feb 26, 2025
265 of 267 checks passed
@bm1549 bm1549 deleted the brian.marks/long-live-yamlfmt branch February 26, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants