Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Telemetry Keys #4178

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

nhulston
Copy link
Contributor

Motivation

Failing tests in: DataDog/dd-trace-dotnet#6655

https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness

Changes

Run ./tests/telemetry_intake/update.sh

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@nhulston nhulston force-pushed the nicholas.hulston/update-telemetry-keys-feb-24 branch from 657a34c to 26f661a Compare February 24, 2025 16:13
@nhulston nhulston marked this pull request as ready for review February 24, 2025 19:05
@nhulston nhulston requested a review from a team as a code owner February 24, 2025 19:05
@nhulston nhulston requested review from quinna-h and removed request for a team February 24, 2025 19:05
@nhulston nhulston merged commit a727074 into main Feb 24, 2025
267 checks passed
@nhulston nhulston deleted the nicholas.hulston/update-telemetry-keys-feb-24 branch February 24, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants