Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] disable non passing tests #4187

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

christophe-papazian
Copy link
Contributor

Motivation

Some non passing tests were unlocked on main after 3.1 release. They should not.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@christophe-papazian christophe-papazian marked this pull request as ready for review February 25, 2025 11:59
@christophe-papazian christophe-papazian requested review from mabdinur and a team as code owners February 25, 2025 11:59
@christophe-papazian christophe-papazian merged commit c0176d6 into main Feb 25, 2025
32 checks passed
@christophe-papazian christophe-papazian deleted the christophe-papazian/unlock_ddtrace_ci branch February 25, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants